Repository navigation
Fix dependent volume flag removal during same-host storage moves - #3138
Merged
Merged
Conversation
Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
Introduce a new boolean argument, cleanupDependencies, to control whether dependent resources are updated when removing a device. Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
…Remove Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
presztak
force-pushed
the
mv_dependent_fix
branch
from
April 2, 2026 14:25
e66613e to
68d6be3
Compare
stgraber
enabled auto-merge
April 2, 2026 14:46
stgraber
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when moving an instance to a different storage on the same host, removing the instance would also clear the
dependentflag on associated volumes. This was incorrect because the instance is recreated on the new storage and dependent volumes should not be modified during this workflow.This PR introduces a new boolean argument
cleanupDependencies, to control whether dependent resources are removed/updated during instance deletion.