Repository navigation
Rework physical NIC device validation - #3143
Merged
Merged
Conversation
bensmrs
requested changes
Apr 3, 2026
When dealing with a physical device that's treated as a bridged device (parent is a type=physical bridge), also send device validation through the bridge logic. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
bensmrs
approved these changes
Apr 3, 2026
bensmrs
enabled auto-merge
April 3, 2026 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to clarify what options of the physical NICs are valid when as that device type is getting a bit complex what with supporting:
This sorts out the conditions for the various properties to cover the first 3 cases and then sends validation through the bridged NIC validator for the 4th case.