Skip to content

Improve import/export usage consistency - #3200

Merged
stgraber merged 6 commits into
lxc:mainfrom
bensmrs:stdin-stdout
Apr 20, 2026
Merged

stgraber merged 6 commits into
lxc:mainfrom
bensmrs:stdin-stdout

Conversation

@bensmrs

@bensmrs bensmrs commented Apr 20, 2026

Copy link
Copy Markdown
Member

This makes all non-image import/export commands support stdin/stdout-like path specs.
(Image commands need quite some cleanup before this can easily be ported, IMO.)
Additionally, this introduces a flag to force overriding backup files and tries to make the overall logic a bit more uniform.

Closes: #3124

@bensmrs
bensmrs requested a review from stgraber as a code owner April 20, 2026 09:27
@github-actions github-actions Bot added Documentation Documentation needs updating API Changes to the REST API labels Apr 20, 2026
@github-actions github-actions Bot removed Documentation Documentation needs updating API Changes to the REST API labels Apr 20, 2026
@bensmrs

bensmrs commented Apr 20, 2026 •

Copy link
Copy Markdown
Member Author

Not sure whether the failing tests really are my fault; re-running them.
Edit: better on the 2nd run; I’m assuming some contention issues on the runners triggering our timeouts…

@stgraber

Copy link
Copy Markdown
Member

@bensmrs I retried them a couple of times but it's the exact same tests failing on all storage backends. I'm not seeing this on other PRs so it's definitely your change causing it :)

@bensmrs

bensmrs commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

Well look at #3201

@bensmrs

bensmrs commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

And the other recent ones also, @stgraber β€―

@stgraber

Copy link
Copy Markdown
Member

@bensmrs yeah, but there's a difference between a PR where one of the "standalone_storage" test fails and one where every single one of them fails with no other testsuite failures ;)

@stgraber

Copy link
Copy Markdown
Member

Piotr's PR, if I retry it a couple of times, I'm 99% sure all those will clear. Yours, I've retried twice and we've not gotten a single green standalone_storage run.

@bensmrs

bensmrs commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

Ceph worked after a retry :)

@stgraber

Copy link
Copy Markdown
Member

Hmm, right and the dir ones went through too, so it's not causing a full failure but it's definitely nudging timings in a pretty significant way :)

@stgraber

Copy link
Copy Markdown
Member

I'm pretty confused as to how importing a container that's less than 5MB large would take 2 minutes though

@bensmrs

bensmrs commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

I’m really not sure it’s the PR. 2 PRs that fix typos also trigger the timeouts. Here, it fails at the exact same place, and my only fix in the instance import route is changing an == with a slices.Contains.

@stgraber

Copy link
Copy Markdown
Member

Yeah, I just went through this PR pretty closely and I don't see it either.

There's nothing in the import codepath that would affect this particular part of the test and none of the changes to the testsuite are messing with the input for the failing test either.

@bensmrs

bensmrs commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

Exactly :D
So I’m happily blaming Azure, with absolutely no proof.

bensmrs added 6 commits April 20, 2026 12:32
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
@stgraber
stgraber merged commit d610a8c into lxc:main Apr 20, 2026
50 of 56 checks passed
@bensmrs
bensmrs deleted the stdin-stdout branch April 22, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Export/Import Custom Storage Volumes to/from Standard Output/Input Using -

2 participants