Repository navigation
Improve import/export usage consistency - #3200
Conversation
|
Not sure whether the failing tests really are my fault; re-running them. |
|
@bensmrs I retried them a couple of times but it's the exact same tests failing on all storage backends. I'm not seeing this on other PRs so it's definitely your change causing it :) |
|
Well look at #3201 |
|
And the other recent ones also, @stgraber β― |
|
@bensmrs yeah, but there's a difference between a PR where one of the "standalone_storage" test fails and one where every single one of them fails with no other testsuite failures ;) |
|
Piotr's PR, if I retry it a couple of times, I'm 99% sure all those will clear. Yours, I've retried twice and we've not gotten a single green |
|
Ceph worked after a retry :) |
|
Hmm, right and the dir ones went through too, so it's not causing a full failure but it's definitely nudging timings in a pretty significant way :) |
|
I'm pretty confused as to how importing a container that's less than 5MB large would take 2 minutes though |
|
Iβm really not sure itβs the PR. 2 PRs that fix typos also trigger the timeouts. Here, it fails at the exact same place, and my only fix in the instance import route is changing an |
|
Yeah, I just went through this PR pretty closely and I don't see it either. There's nothing in the import codepath that would affect this particular part of the test and none of the changes to the testsuite are messing with the input for the failing test either. |
|
Exactly :D |
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
This makes all non-image import/export commands support stdin/stdout-like path specs.
(Image commands need quite some cleanup before this can easily be ported, IMO.)
Additionally, this introduces a flag to force overriding backup files and tries to make the overall logic a bit more uniform.
Closes: #3124