Skip to content

Various bugfixes - #3352

Merged
stgraber merged 5 commits into
lxc:mainfrom
stgraber:main
May 19, 2026
Merged

stgraber merged 5 commits into
lxc:mainfrom
stgraber:main

Conversation

@stgraber

Copy link
Copy Markdown
Member

No description provided.

stgraber added 4 commits May 19, 2026 02:50
Skip OVN setup when network.ovn.northbound_connection is empty so nodes
without OVS installed can apply the config change after the cluster
unsets OVN. During cluster join, drop OVN config keys from the trigger
changes map since the explicit setup calls already handle them with
error tolerance, preventing a join from failing on nodes that lack OVS.

Closes lxc#3351

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
GetResources only cares about top-level statistics and so shouldn't be
triggering a full cache run. This was making cluster state retrieval
extremely slow.

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Sponsored-by: https://webdock.io
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@bensmrs

bensmrs commented May 19, 2026

Copy link
Copy Markdown
Member

LINSTOR looks unhappy, I’ll rerun the checks

@bensmrs

bensmrs commented May 19, 2026 •

Copy link
Copy Markdown
Member

The error has been ignored in a few PRs now. It first appeared in #3338, which suggests it’s an upstream change.

sigh https://github.com/LINBIT/linstor-server/blob/master/CHANGELOG.md#1333---2026-05-11

Any idea what’s causing a shrink anyway @stgraber?

@stgraber

Copy link
Copy Markdown
Member Author

@bensmrs The standalone case appears to be an actual container shrink test, so that's now failing given they removed support for it. The cluster case is less obvious but may also be effectively the same thing. The pool's default volume size would be 10GiB. If the container's profile instead sets something smaller, then a shrink would happen on creation which would similarly fail.

So I think the errors are correct from the Incus side, it's the tests that will need updating and probably a note added to the documentation.

lxc/lxc#4635

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@bensmrs

bensmrs commented May 19, 2026

Copy link
Copy Markdown
Member

Ok, I’ll have a look

@stgraber
stgraber merged commit 22bd738 into lxc:main May 19, 2026
52 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants