Repository navigation
Add additional validation to device names - #3423
Merged
Merged
Conversation
Have all device name sent through validate.IsAPIName to limit the maximum length and avoid issues with filesystem paths. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Consistently use linux.PathNameEncode across all device paths. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
bensmrs
approved these changes
May 28, 2026
Member
|
Looks like the tests are using colons in device names |
Member
Author
|
Fixed, that was quite the terrible device name ;) |
Member
|
_definitely_a_valid_name :) |
Member
|
Nah, remove L56-59, @stgraber |
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Member
Author
|
Nuked a bunch of them. No idea why a random network test is doing device name validation like that... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.