Skip to content

Incus/add remote set keepalive - #3495

Merged
stgraber merged 5 commits into
lxc:mainfrom
augustodsgv:incus/add-remote-set-keepalive
Jun 14, 2026
Merged

stgraber merged 5 commits into
lxc:mainfrom
augustodsgv:incus/add-remote-set-keepalive

Conversation

@augustodsgv

Copy link
Copy Markdown
Contributor

Discussed in #3424

Adds new incus remote set-keepalive subcommand for managing remote keepalive
Updates remote docs with keepalive configuration via CLI commands
Fixes incus keepalive comment typo
Fixes incus alias help message typo introduced by #3479
Updates i18n to match CLI modifications

@augustodsgv
augustodsgv requested a review from stgraber as a code owner June 14, 2026 01:45
@github-actions github-actions Bot added the Documentation Documentation needs updating label Jun 14, 2026
@augustodsgv
augustodsgv force-pushed the incus/add-remote-set-keepalive branch from 01e160d to d9478c6 Compare June 14, 2026 01:47
@stgraber

Copy link
Copy Markdown
Member

Static analysis picked up a type:

cmd/incus/remote.go:1507: Validade ==> Validate

@stgraber

Copy link
Copy Markdown
Member

Other than that, looks good to me, thanks!

@augustodsgv
augustodsgv force-pushed the incus/add-remote-set-keepalive branch from d9478c6 to b602128 Compare June 14, 2026 02:00
@augustodsgv

Copy link
Copy Markdown
Contributor Author

Seems like I messed up with my git tree again :(. I think I included one commit that was not mine to the rebase while trying fix the typo, which added me as a coauthor, even though I didn't edited it. Is there an easy way of fixing it?

@stgraber

Copy link
Copy Markdown
Member

Rebasing the branch on origin/main + force push should clean that up. I'll do it for you now.

Signed-off-by: augustodsgv <augustodsgv@gmail.com>
Signed-off-by: augustodsgv <augustodsgv@gmail.com>
Signed-off-by: augustodsgv <augustodsgv@gmail.com>
Signed-off-by: augustodsgv <augustodsgv@gmail.com>
Signed-off-by: augustodsgv <augustodsgv@gmail.com>
@stgraber
stgraber force-pushed the incus/add-remote-set-keepalive branch from b602128 to 4b10c51 Compare June 14, 2026 03:02
@augustodsgv

augustodsgv commented Jun 14, 2026 •

Copy link
Copy Markdown
Contributor Author

Okay, that was simple, I was afraid that it would leave the branch in a state worst than before. Again, I appreciate your patience :).

@stgraber
stgraber merged commit 9460b4b into lxc:main Jun 14, 2026
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Documentation needs updating

Development

Successfully merging this pull request may close these issues.

2 participants