Skip to content

incusd/seccomp: Report FUSE mount helper failures - #3694

Merged
stgraber merged 1 commit into
lxc:mainfrom
fivetime:upstream-fuse-helper-errors
Jul 24, 2026
Merged

stgraber merged 1 commit into
lxc:mainfrom
fivetime:upstream-fuse-helper-errors

Conversation

@fivetime

Copy link
Copy Markdown
Contributor

Report contextual errors from the intercepted FUSE mount helper and retain its stderr in the seccomp debug context. The existing syscall fallback behavior is unchanged. Tested with: go test ./internal/server/seccomp ./cmd/incusd

@fivetime
fivetime requested a review from stgraber as a code owner July 23, 2026 04:30
Signed-off-by: Simon Zhou <jp.zdm2008@gmail.com>
@stgraber
stgraber force-pushed the upstream-fuse-helper-errors branch from b6a012e to 0401f92 Compare July 24, 2026 04:15
@stgraber

Copy link
Copy Markdown
Member

Reworked this one quite a bit as the logic was pretty wrong.

stderr in forksyscall is meant as a way to send back an errno, it's not meant to be used for general purpose fprintf. The change as it was made would cause a mix of errno and string which could confuse parsers.

The Go error handling logic was also needlessly complex when the main point is to make sure the error is caught and included in the context.

So updated the PR to do just that. If we want more detailed error logging, more significant rework of forksyscall would be needed.

@stgraber
stgraber merged commit 2652e97 into lxc:main Jul 24, 2026
54 of 57 checks passed
@fivetime
fivetime deleted the upstream-fuse-helper-errors branch July 26, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants