Repository navigation
incusd/seccomp: Report FUSE mount helper failures - #3694
Merged
Merged
Conversation
Signed-off-by: Simon Zhou <jp.zdm2008@gmail.com>
stgraber
force-pushed
the
upstream-fuse-helper-errors
branch
from
July 24, 2026 04:15
b6a012e to
0401f92
Compare
Member
|
Reworked this one quite a bit as the logic was pretty wrong. stderr in forksyscall is meant as a way to send back an errno, it's not meant to be used for general purpose fprintf. The change as it was made would cause a mix of errno and string which could confuse parsers. The Go error handling logic was also needlessly complex when the main point is to make sure the error is caught and included in the context. So updated the PR to do just that. If we want more detailed error logging, more significant rework of forksyscall would be needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report contextual errors from the intercepted FUSE mount helper and retain its stderr in the seccomp debug context. The existing syscall fallback behavior is unchanged. Tested with: go test ./internal/server/seccomp ./cmd/incusd