Repository navigation
Client-side near-live migration - #3754
Merged
Merged
Conversation
presztak
force-pushed
the
client_nearlive
branch
from
July 31, 2026 13:59
1c778ab to
bcc0f26
Compare
presztak
marked this pull request as ready for review
July 31, 2026 15:59
stgraber
reviewed
Aug 1, 2026
stgraber
reviewed
Aug 1, 2026
stgraber
reviewed
Aug 1, 2026
stgraber
reviewed
Aug 1, 2026
stgraber
reviewed
Aug 1, 2026
stgraber
reviewed
Aug 1, 2026
Member
|
Logic generally seems fine but the over-use of small functions actually makes it harder for me to follow and understand the flow. The use of functions and const all makes sense if they're called multiple times (we don't want to duplicate code or const) but it's not the case here and it just makes it harder to follow. |
presztak
force-pushed
the
client_nearlive
branch
from
August 1, 2026 10:19
bcc0f26 to
f9a093d
Compare
stgraber
reviewed
Aug 2, 2026
Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
…inal sync In near-live migration, dependent volumes are handled separately during the third pass. Including them in the final sync is redundant and should be prevented. Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
presztak
force-pushed
the
client_nearlive
branch
from
August 2, 2026 14:56
f9a093d to
bce8318
Compare
Member
|
@presztak in your follow-up PR can you add system testing for this stuff? It should be possible to test it easily enough when running the testsuite on ZFS or btrfs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Near-live migration for the cluster <-> cluster case.
Part of: #3059