Repository navigation
Allow live update of ipv4/ipv6.address.external - #3772
Merged
Merged
Conversation
CreateLogicalRouterNAT only matched existing rules on the exact pair, so re-running it for a per NIC egress SNAT rule with a new external address left the previous rule for that internal IP in place instead of replacing it. Signed-off-by: 0xk1f0 <dev@k1f0.dev>
Changing ipv4.address.external or ipv6.address.external on a NIC attached to a running instance was not in UpdatableFields, so it triggered a full device remove and re-add instead of an in-place update. This in turn triggered an error when the instance's agent is not up and running. Signed-off-by: 0xk1f0 <dev@k1f0.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a change of either
ipv4oripv6.address.externalof an instance's NIC triggers a full re-attach. For these two properties, this action is not strictly needed and limits when they can be applied. As of right now, I was seeing errors when applying a.externaladdress when an instance's agent is not fully ready yet.This fix exempts these two properties in
UpdatableFieldsand additionally makes sure stale SNAT rules are replaced correctly when addresses change.