Repository navigation
Allow sharing specific networks with restricted projects - #3875
Merged
Merged
Conversation
…tworks.access Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
bensmrs
approved these changes
Aug 21, 2026
| return project.ImageProjectFromRecord(p) | ||
| } | ||
|
|
||
| if objectType == auth.ObjectTypeNetwork && len(muxVars) > 0 { |
Member
There was a problem hiding this comment.
For my culture, when does len(muxVars) == 0 in that context?
Member
Author
There was a problem hiding this comment.
Just panic prevention to avoid a potential access of a non-existent index. Though currently all codepaths using a network object type do pass at least a name through.
Member
There was a problem hiding this comment.
Still, there are plenty of places in this function that don’t check it, so we may wanna be a tad more consistent on those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for sharing of specific networks from the
defaultproject with another project which has bothfeatures.networks=true(OVN) andrestricted=trueenabled.In that scenario, setting
restricted.networks.accessallows read-only access of specific managed networks.The reason for all this is to have projects which are otherwise isolated with their own network view (OVN) to still be passed a select set of administrator-managed networks.
A concrete example of this would be an environment where a tenant has access to a project with OVN enabled. They can create their own OVN networks but there's also a physical network (VLAN) which they need to be able to access.
That's exactly the case we're running into with the Linux Containers lab where the majority of our networks are OVN networks for Github runners or similar builders, but we also have a physical lab with physical machines sitting on a VLAN which we need to access from within the environment.