Skip to content

Add NVRAM support in QEMU scriptlet - #3878

Merged
stgraber merged 14 commits into
lxc:mainfrom
bensmrs:efi
Aug 21, 2026
Merged

stgraber merged 14 commits into
lxc:mainfrom
bensmrs:efi

Conversation

@bensmrs

@bensmrs bensmrs commented Aug 21, 2026

Copy link
Copy Markdown
Member

This also adds tests and fixes bugs.

d80202a solved an issue introduced when implementing bulk NVRAM
operations, but broke the intended behavior of unsetting NVRAM variables
when setting to an empty string. This commit ensures both code paths are
sane.

Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
@bensmrs
bensmrs requested a review from stgraber as a code owner August 21, 2026 15:52
@github-actions github-actions Bot added Documentation Documentation needs updating API Changes to the REST API labels Aug 21, 2026
@bensmrs
bensmrs force-pushed the efi branch 3 times, most recently from b50b19f to 4557cab Compare August 21, 2026 20:57
@bensmrs

bensmrs commented Aug 21, 2026 •

Copy link
Copy Markdown
Member Author

Well, I can’t get interactions with the console to behave within the CI, so I’ll patch the test into something less funny. I have solved that with longer sleeps.

@bensmrs
bensmrs force-pushed the efi branch 3 times, most recently from d9ba9ae to 86257d3 Compare August 21, 2026 22:03
bensmrs added 13 commits August 21, 2026 22:05
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
@stgraber
stgraber merged commit 7b02e0e into lxc:main Aug 21, 2026
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Changes to the REST API Documentation Documentation needs updating

Development

Successfully merging this pull request may close these issues.

2 participants