Skip to content

Dont interpret ErrNonReusuableSucceeded as failure on instance delete - #4076

Merged
stgraber merged 2 commits into
lxc:mainfrom
DarkressX:error-on-delete-success
Sep 25, 2026
Merged

stgraber merged 2 commits into
lxc:mainfrom
DarkressX:error-on-delete-success

Conversation

@DarkressX

Copy link
Copy Markdown
Contributor

No description provided.

…ceeded as error

Signed-off-by: Leon Schoch <lschoch@anexia.com>
…eeded as error

Signed-off-by: Leon Schoch <lschoch@anexia.com>
@DarkressX
DarkressX marked this pull request as ready for review September 25, 2026 16:28
@DarkressX
DarkressX requested a review from stgraber as a code owner September 25, 2026 16:28
@stgraber

Copy link
Copy Markdown
Member

Hmm, is that right? Doesn't it mean that if I trigger a delete when the instance is migrating or stopping or something and that background operation succeeds we'll now return as if the delete has also succeeded?

@DarkressX

Copy link
Copy Markdown
Contributor Author

I don't think so. The CreateWaitGet function only returns the ErrNonReusuableSucceeded error if the action type matches. So this should only return if a delete call is triggered twice, right?

@stgraber
stgraber merged commit 14b7e4b into lxc:main Sep 25, 2026
93 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants