Repository navigation
Fix some dependent volume issues - #4137
Merged
Merged
Conversation
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
When copying an instance from one of its snapshots, the dependent volumes were copied from their current state. Use the volume snapshot matching the instance snapshot instead, in both the same-pool and the cross-pool paths. The latter also needed its dependent volume transfer enabled for snapshot sources, which crashed on the missing instance section of the snapshot's config. Closes lxc#4125 Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
A refresh request carries the source's devices, so the dependent volume check refused it unless the overrides were passed again. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
The snapshot records of a copy kept the source's dependent volume names, so restoring them touched the source's volumes and refreshes failed validation. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
The refresh update is built from the source, which re-pointed the dependent devices at the source's volumes and dropped a root disk device the target got from --storage. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
presztak
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.