Repository navigation
internal/server/bgp: Preserve shared peer counts - #4169
Merged
Merged
Conversation
Signed-off-by: Jason Overmier <jason.r.overmier@gmail.com>
stgraber
force-pushed
the
fix-bgp-peer-reference-count
branch
from
October 12, 2026 02:50
fa9444f to
e7465ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple networks share a BGP peer, listener reconfiguration recreates the peer with a reference count of one. Removing one network can then remove the native peer while another network still needs it.
Preserve each peer's reference count when recreating it. Add a focused regression for peers queued before startup and peers on an already-running listener, checking the native GoBGP peer remains until its last reference is removed.
Validation: both cases fail on main and pass with the fix, including repeated race checks. Full Go tests, static-analysis recipes, and daemon/CLI builds pass.