Skip to content

fix(helm): coerce OmsAgent.isUsingAADAuth to a boolean - #1679

Merged
rashmichandrashekar (rashmichandrashekar) merged 2 commits into
ci_prodfrom
rashmi/aad-auth-fix
May 13, 2026
Merged

rashmichandrashekar (rashmichandrashekar) merged 2 commits into
ci_prodfrom
rashmi/aad-auth-fix

Conversation

@rashmichandrashekar

Copy link
Copy Markdown
Contributor

Helm --set and quoted YAML both deliver this value as a string. Any non-empty string is truthy in Go templates, so the literal string false was evaluating to true and enabling AAD-only RBAC/secret references in ama-logs.yaml. Compare the lowercased string to true to coerce it into a real boolean.

Helm --set and quoted YAML both deliver this value as a string. Any non-empty string is truthy in Go templates, so the literal string false was evaluating to true and enabling AAD-only RBAC/secret references in ama-logs.yaml. Compare the lowercased string to true to coerce it into a real boolean.
…s chart

Same Go-template bug as the prod-clusters chart: \ was being assigned the raw value of .Values.OmsAgent.isUsingAADAuth (or .Values.amalogs.useAADAuth for Arc), which Helm delivers as a string from quoted YAML or --set. The string "false" is non-empty, so {{ if \ }} evaluated to true and the AAD-only RBAC / secrets / deployment / hpa / service / env-var paths were rendered even when AAD was disabled.

Coerce to a real bool via (eq (lower (toString val)) "true") in all 7 affected templates: ama-logs-daemonset.yaml, ama-logs-daemonset-windows.yaml, ama-logs-deployment.yaml, ama-logs-deployment-multitenancy.yaml, ama-logs-hpa.yaml, ama-logs-rbac.yaml, ama-logs-service.yaml.
@rashmichandrashekar
rashmichandrashekar (rashmichandrashekar) merged commit c9247b5 into ci_prod May 13, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants