Skip to content

Updated to MAY21 - #1897

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
himanshu007-creator:patch-1
May 21, 2021
Merged

Updated to MAY21#1897
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:mainfrom
himanshu007-creator:patch-1

Conversation

@himanshu007-creator

@himanshu007-creator Himanshu (himanshu007-creator) commented May 3, 2021

Copy link
Copy Markdown
Contributor

Resolves #1896

@himanshu007-creator
Himanshu (himanshu007-creator) requested a review from a team as a code owner May 3, 2021 05:12
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the enhancement Something can be improved label May 3, 2021
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks!

I've edited your PR description to say "Resolves" instead of "Solves" - this is because GitHub (as their documentation explains) considers various forms of "Closes", "Fixes", and "Resolves" to be special - using them will "link" a pull request to an issue, such that merging the PR will automatically close the issue. Anything else will "mention" an issue (appearing in its history) but won't set up that auto-closing link. Not a problem, just thought I'd mention it for the future! 😺

@himanshu007-creator

Himanshu (himanshu007-creator) commented May 3, 2021

Copy link
Copy Markdown
Contributor Author

Thanks!

I've edited your PR description to say "Resolves" instead of "Solves" - this is because GitHub (as their documentation explains) considers various forms of "Closes", "Fixes", and "Resolves" to be special - using them will "link" a pull request to an issue, such that merging the PR will automatically close the issue. Anything else will "mention" an issue (appearing in its history) but won't set up that auto-closing link. Not a problem, just thought I'd mention it for the future! 😺

Sure! I generally use "resolved", missed this time😬

@StephanTLavavej

Copy link
Copy Markdown
Member

Apologies for the delay here - we're usually faster at merging PRs, but our process is semi-manual (as we have to mirror GitHub PRs to the internal MSVC repo where the product is officially built) and several members of the team including me have been on vacation πŸ–οΈ. I believe we should be able to merge your PR next week, stay tuned.

@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for updating this version macro, and congratulations on your first microsoft/STL commit! πŸŽ‰ 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to May 2021

3 participants