Changed _Unfancy_maybe_null() to _Unfancy() - #2508
Changed _Unfancy_maybe_null() to _Unfancy()#2508Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
Conversation
Stephan T. Lavavej (StephanTLavavej)
added
the
enhancement
|
I looked at all of the codepaths that can call this function, and I don't believe that any of them can pass null pointers now, so this appears to be completely correct. 🎉 |
|
By the way, I've edited your PR description to say "Fixes" instead of "Addresses". This activates GitHub's close/fix/resolve syntax, which will automatically close the issue when this PR is merged. (Otherwise it's just a "mention" without auto-closing behavior.) |
Casey Carter (CaseyCarter)
left a comment
Casey Carter (CaseyCarter)
left a comment
There was a problem hiding this comment.
LGTM as well. I pushed a small change to document the non-null preconditions with _STL_INTERNAL_CHECK so they'll be nicely visible.
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for improving this code, and congratulations on your first microsoft/STL pull request! 😸 🎉 🚀 This change will appear in VS 2022 17.2 Preview 2 along with the rest of the ASan |
5 participants
Fixes #2470 and changes instances of
_Unfancy_maybe_null()to_Unfancy().