allow %x for formatting year_month_day - #2762
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoJun 16, 2022
Merged
Conversation
…_month_weekday, year_month_weekday_last
Casey Carter (CaseyCarter)
added
bug
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 7, 2022
Member
|
I believe that this is correct (although the Standard is unusually elliptical in this area, these types do provide the necessary information). |
Charlie Barto (barcharcraz)
approved these changes
Jun 15, 2022
Charlie Barto (barcharcraz)
left a comment
Charlie Barto (barcharcraz)
left a comment
Contributor
There was a problem hiding this comment.
This looks good. Ideally, we would test the locale specific orderings, but with current test coverage this looks like a strict improvement, even if the locale stuff were to be broken so I don't feel it needs those tests to be merged.
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for fixing this chronat bug! 📅 ✏️ 🎉 |
Igor Zhukov (fsb4000)
added a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2761
I'm not sure if it's correct.
C++ standard is unclear: https://eel.is/c++draft/time.format#6
But cppreference says that
%xis supported for year_month_day, year_month_day_last, year_month_weekday and year_month_weekday_last