Cleanup tests to be friendlier to modules - #3034
Merged
Stephan T. Lavavej (StephanTLavavej) merged 7 commits intoAug 16, 2022
Merged
Cleanup tests to be friendlier to modules#3034Stephan T. Lavavej (StephanTLavavej) merged 7 commits into
Stephan T. Lavavej (StephanTLavavej) merged 7 commits into
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
August 15, 2022 04:25
Contributor
Think the reverse was deliberate for throughput. |
Contributor
|
Ah, never mind, it is test code. |
nicole mazzuca (strega-nil-ms)
approved these changes
Aug 15, 2022
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While experimentally running
tests/stdwith Standard Library Modules, I encountered unnecessary dependencies on macros and non-Standard code. Although we're a long way from routinely running module configurations intests/std, I'd like to clean up what I've found so far._Is_any_of_v. We can useis_same_vinstead of this internal machinery, at minimal verbosity cost.numeric_limitsinstead of macros.std::integral,std::numbers,std::expected. Afterimport std; using namespace std;, if test code has global-scopeintegral,numbers, andexpected, mentioning them unqualified is ambiguous. (This is theoretically an issue for headers too, as any header is allowed to drag in any other header.)<cinttypes>print macros. These are difficult to read in any event, andstatic_casts are probably less annoying.