Add unwrapping to move_sentinel - #3098
Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits intoSep 13, 2022
Merged
Conversation
nicole mazzuca (strega-nil-ms)
requested a review
from a team
as a code owner
September 12, 2022 17:08
nicole mazzuca (strega-nil-ms)
added
enhancement
Stephan T. Lavavej (StephanTLavavej)
removed
the
enhancement
Member
|
Adjusting labels - we usually use |
Stephan T. Lavavej (StephanTLavavej)
left a comment
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Thanks! Looks good, all I found were 3 tiny nitpicks, and IIRC you also prefer brace construction when possible, so I'll validate and push changes to save time. (I'd request changes if I were less sure you'd prefer them.)
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Sep 12, 2022
Casey Carter (CaseyCarter)
approved these changes
Sep 12, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for this ranges performance improvement! 🚀 🎉 😻 🎁 |
Casey Carter (CaseyCarter)
pushed a commit
to CaseyCarter/STL
that referenced
this pull request
Oct 6, 2022
Co-authored-by: Nicole Mazzuca <mazzucan@outlook.com> Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3009
There are two new concepts -
_Weakly_unwrappable_sentineland_Weakly_unwrappable_iterator- these are useful for implementation of wrapper types which are unwrappable when their underlying type is unwrappable (likemove_iterator/move_sentinel)