Repository navigation
[Issue 5395] Fix msbuild warnings - #5685
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
8635895 to
d418f2c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
address comment
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit 1d825e6.
|
We found that this PR blocked the foundation version update in winUI. I am also trying to resolve this warning, we can discuss the details through Teams. |
No worries. chatted with Sarah and devised a better technique that should be compatible with Xaml's generated code behavior. Essentially, this should ensure that any auto-initializer preprocessor definitions are added after ALL compilation sources (to ensure no batching occurs):
|
Summary
This PR attempts to fix the following msbuild warning:
warning MSB8027: Two or more files with the name of WindowsAppRuntimeAutoInitializer.cpp will produce outputs to the same location. This can lead to an incorrect build result.
This build warning seems to be caused by:
MSB4120: Item 'ClCompile' definition within target references itself via (qualified or unqualified) metadatum 'PreprocessorDefinitions'. This can lead to unintended expansion and cross-applying of pre-existing items. More info: https://aka.ms/msbuild/metadata-self-ref
This PR eliminates duplicate output by disabling MSBuild batching and applying PreProcessorDefinitions uniformly across all source files.
Testing
Confirmed that the warning no longer appears in the MSBuild binlog during repro testing.
Pipeline builds
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.