Repository navigation
[WebNN EP] Support SkipLayerNormalization op - #32377
Merged
Dwayne Robinson (fdwr) merged 2 commits intoSep 3, 2026
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
|
Dwayne Robinson (@fdwr), PTAL, thanks! |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The implementation uses the wrong default epsilon, incompletely validates its decomposition, and lacks WebNN-specific coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds WebNN support for SkipLayerNormalization via residual addition and native layer normalization.
Changes:
- Registers and maps the operator.
- Implements residual/bias handling and optional sum output.
- Updates operator documentation.
File summaries
| File | Description |
|---|---|
op_builder_factory.cc |
Registers the operator builder. |
map_info.h |
Adds WebNN operation mapping. |
normalization_op_builder.cc |
Implements decomposition and validation. |
webnn-operators.md |
Documents WebNN support. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Copilot, comments addressed, pls. take another look, thanks! |
Wanming Lin (Honry)
force-pushed
the
support-SkipLayerNormalization
branch
from
September 3, 2026 00:12
c6122b8 to
32f769e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SkipLayerNormalizationcan be decomposed byLayerNormalization+Add.