Repository navigation
Get rid of spurious warning about not being able to find spectre mitigation - #32516
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new vswhere/vcvarsall setup does not fail fast when discovery fails, which can lead to confusing downstream pipeline failures.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Windows Azure Pipelines packaging template to explicitly locate and run Visual Studio’s VC environment setup script (vcvars64.bat) via vswhere, aiming to eliminate a spurious “spectre mitigation not found” warning by ensuring the intended toolchain environment is initialized.
Changes:
- Add a
vswhere-based step to locatevcvars64.batand export it as thevcvarsallpipeline variable. - Add a
BatchScript@1step to run$(vcvarsall)and modify the job environment before invokingbuild.py.
File summaries
| File | Description |
|---|---|
| tools/ci_build/github/azure-pipelines/templates/win-ci.yml | Adds VS toolchain discovery and VC environment initialization steps prior to building/testing. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Tianlei Wu (tianleiwu)
approved these changes
Sep 9, 2026
Tianlei Wu (tianleiwu)
enabled auto-merge (squash)
September 9, 2026 23:59
Tianlei Wu (tianleiwu)
deleted the
dev/erscor/2026/9/9-debug-spectre
branch
September 10, 2026 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context