Repository navigation
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Expected AutoEP duplicates currently emit a misleading session-options warning.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Deduplicates AutoEP-provided custom-op domains before session registry creation.
Changes:
- Filters duplicate domains across AutoEP devices.
- Preserves session-option conflict handling across both model-loading paths.
| File | Description |
|---|---|
onnxruntime/core/session/utils.cc |
Deduplicates collected AutoEP custom-op domains. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Skip EP-provided custom-op domains that were already collected from another AutoEP device before registering the session-local custom registry.
kuanyul-qti
force-pushed
the
dev/kuanyul-qti/fix-customop-domain-duplicate
branch
from
September 21, 2026 09:54
6634b79 to
4cafd17
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The multi-device failure and both modified loading paths need regression coverage.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
Resolved since last review (1)
Contributor
Author
|
@microsoft-github-policy-service agree company="Qualcomm" |
Contributor
Author
|
Hi Xavier Dupré (@xadupre) , Could you help trigger the CI workflow? Thanks. |
mirounga
self-requested a review
September 24, 2026 16:08
mirounga
approved these changes
Sep 24, 2026
This was referenced Sep 29, 2026
[QNN EP] Add support for Buffer, StatefulLstm, StatefulGru block ops
onnxruntime/onnxruntime-qnn#608
Closed
This was referenced Oct 9, 2026
This was referenced Nov 2, 2026
Open
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
AutoEP can select and expose multiple
OrtEpDeviceinstances for a single session. Some of those devices may be backed by the same EP factory, so querying each device for custom-op domains can return repeated domains.ORT gathers all EP-provided custom-op domains into one session-local collection and registers them with the session's custom registry before model load. That registry expects each domain to be unique. If the same domain is registered twice, registration fails with "Domain already set in registry", even though the duplicate came from equivalent AutoEP devices rather than user configuration.
This mainly affects multi-device AutoEP sessions. Single-device AutoEP sessions do not hit the issue because only one copy of the domain is collected.
Description
Deduplicate custom-op domains collected from AutoEP devices before registering them with the session-local custom registry.
The change keeps only one copy of each EP-provided custom-op domain while still skipping domains already supplied through session options.
This ports the AutoEP custom-op domain deduplication from onnxruntime/onnxruntime-qnn#608.