Skip to content

Full support for dark theme #733

Closed
Closed

Description

@SameExpert

Is your feature request related to a problem? Please describe.
On Linux (KDE Plasma) I'm having dark theme. It looks odd if LosslessCut stays out light-themed when everything else is dark.

Describe the solution you'd like
LosslessCut should support for dark mode. There can be an option in settings for Dark mode / Light mode / System default (if possible)

Describe alternatives you've considered
As it depends on gtk3, system's GTK settings should be used.

Activity

  1. mifi commented on May 5, 2021

    @mifi
    Owner

    losslesscut is a cross platform app so it doesn't use native widgets like GTK. it could however try to follow colors. however losslesscut UI is already rather dark. can you provide a screenshot of what you mean by It looks odd if LosslessCut stays out light-themed when everything else is dark. ?

  2. SameExpert commented on May 5, 2021

    @SameExpert
    Author

    The main windows is OK (even though it's tool-tips are brightened it's not much). But this window is so brightened and doesn't suite for dark themes:
    Screenshot__1

  3. changed the title [-][UI] Support for dark theme[/-] [+]Full support for dark theme[/+] on Jan 15, 2022
  4. mifi commented on Dec 18, 2022

    @mifi
    Owner

    The problem is that the UI components of evergreen-ui don’t look very good on a dark background. But as evergreen now has theming support, I think we could define a dark theme.

    if someone wants to try to make a dark theme for evergreen that would be a start

    https://evergreen.segment.com/introduction/theming

  5. added a commit that references this issue on Feb 11, 2024
    9b027bc
  6. miku-orb commented on Apr 3, 2024

    @miku-orb

    Am I blind or is the dark mode config setting not exposed anywhere in the UI settings?

  7. mifi commented on Apr 3, 2024

    @mifi
    Owner

    lower left
    Screenshot 2024-04-03 at 22 38 54

  8. miku-orb commented on Apr 8, 2024

    @miku-orb

    Ahhh, in advanced view, thank you. Though I suggest considering perhaps adding it somewhere to the settings view too for completeness sake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions