Repository navigation
Keep the first filter section heading visible when scrolling - #1940
Merged
ddennedy merged 1 commit intoOct 18, 2026
Merged
Conversation
Member
|
I tested and it works. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrolling to the top of a long Filters list currently snaps the first filter row to the top and hides its section heading. Keep the heading visible while preserving row alignment elsewhere by changing only the existing
snapModebinding.Fixes #1933.
Alternatives considered
Several alternatives were tested. Removing
SnapToItemfixed the hidden heading but also removed row alignment throughout the list. Sticky section headings worked, but introduced a visible UI change. Adjusting the preferred highlight offset also passed the checks, although it changed alignment throughout the list and depended on row geometry.Disabling snapping only at the upper boundary fixed the heading but interrupted downward scrolling. Adding an empty header, using a first-row threshold, or correcting the position after movement ended did not reliably resolve the issue.
The selected solution disables snapping while the list is moving or positioned at the very top. After scrolling stops elsewhere,
SnapToItemrestores row alignment. Includingmovingprevents snapping from being re-enabled during an active scroll, which would interrupt that movement. This keeps the heading visible and preserves alignment with a change to one existing property.Validation
All 15 isolated Qt checks passed, covering wheel scrolling, inertia, row alignment, selection, keyboard navigation, scrollbar dragging, and filter reordering.
The checks load the actual
AttachedFilters.qmlcomponent with a mock model and a minimal Metadata type on Qt 6.8.2, using the Basic controls style, the offscreen platform, and software rendering. The upstream version fails the heading visibility check with an 18-pixel offset; the patched version passes. The temporary test harness is outside the repository and is not included in this PR.