Skip boltdb update call when queue is empty - #3261
Merged
tonistiigi merged 1 commit intoNov 8, 2022
Merged
Conversation
This prevents unnecessary calls (and disk writes) to the metadata cache db when there are no items in the queue. Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
alexcb
marked this pull request as ready for review
November 8, 2022 21:23
tonistiigi
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents unnecessary calls (and disk writes) to the metadata cache db when there are no items in the queue.
Some quick testing on my laptop with a cache containing 26,000 items; this change reduced buildkit startup time from roughly 46 seconds down to 2 seconds.