Repository navigation
Enhance ls manifest description with schema - #1854
Conversation
chrbertsch
left a comment
chrbertsch
left a comment
There was a problem hiding this comment.
Shall we include a graphical illustration of the new schema as for the other schemas?
PTaeuberDS
left a comment
PTaeuberDS
left a comment
There was a problem hiding this comment.
This is basically the proposal that I made in fmi-ls-xcp so it's fine for me.
| <xs:attribute ref="fmi-ls:fmi-ls-description" use="required"/> | ||
| </xs:attributeGroup> | ||
|
|
||
| <xs:element name="FMILSManifest"> |
There was a problem hiding this comment.
Not sure if I like the casing. Maybe we should stick to simple camel case as in "fmiModelDescription"?
There was a problem hiding this comment.
I've regularized and spelt out the naming some more.
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="fmi_ls_manifest_example_schema.xsd" | ||
| xmlns:fmi-ls="http://fmi-standard.org/fmi-ls-manifest" | ||
| fmi-ls:fmi-ls-name="org.fmi-standard.demo-ls-name" |
There was a problem hiding this comment.
Do we need the attribute prefix in addition to the namespace? Wouldn't "fmi-ls:name" be sufficient?
There was a problem hiding this comment.
It technically would, however it is probably still a good idea to have the more explicit names, given that in some circumstances the namespace is not readily apparent.
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" | ||
| xmlns:vc="http://www.w3.org/2007/XMLSchema-versioning" elementFormDefault="qualified" | ||
| vc:minVersion="1.1" |
There was a problem hiding this comment.
Is version=1.1 necessary for this example? Otherwise we could remove it.
There was a problem hiding this comment.
Not needed, just happened to be in there...
|
It would be good to finalize and merge this. |
This adds a schema for the manifest attributes and the default minimal manifest, and enhances the examples to showcase that to some extent.