Skip to content

Initial draft of clock support - #24

Merged
pmai merged 3 commits into
mainfrom
feature/clocks-support
May 8, 2024
Merged

pmai merged 3 commits into
mainfrom
feature/clocks-support

Conversation

@pmai

@pmai pmai commented Nov 17, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@pmai pmai added this to the 2.0-alpha.1 milestone Nov 17, 2023
@pmai pmai self-assigned this Nov 17, 2023
@JochenKoehler
JochenKoehler marked this pull request as ready for review November 24, 2023 14:46
@JochenKoehler

Copy link
Copy Markdown
Collaborator

Web meeting 2023-11-24
Ulrich, Klaus will review this pull request

@pmai
pmai force-pushed the feature/clocks-support branch from c9acc94 to 03c3c2b Compare March 1, 2024 13:07
@JochenKoehler

Copy link
Copy Markdown
Collaborator

Web meeting 2024-03-15:
Some documentation should be added --> Pierre will prepare a draft

Comment thread docs/5___ssd.adoc Outdated

@masoud-najafi masoud-najafi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a short comment about this phrase: "It is implementation-defined whether and which connections between two connectors of kind input with intervalVariability that is not triggered are allowed." This leaves the door open for different interpretations about connecting these "time-based" clocks. For example as you indicated for establishing a constraint equality or have a union of several clock ticks. This would make an SSP model with such connections completely tool dependent.

@pmai

pmai commented May 8, 2024

Copy link
Copy Markdown
Collaborator Author

Just a short comment about this phrase: "It is implementation-defined whether and which connections between two connectors of kind input with intervalVariability that is not triggered are allowed." This leaves the door open for different interpretations about connecting these "time-based" clocks. For example as you indicated for establishing a constraint equality or have a union of several clock ticks. This would make an SSP model with such connections completely tool dependent.

Indeed it does, however as there is currently no established practice on how to handle this across tools, I think this is currently the only thing we can do. If common or multiple common practice is established, we can either tighten the requirements in future releases, and/or add additional attributes to select between multiple ways.

Co-authored-by: Klaus Schuch <klaus.schuch@avl.com>
@JochenKoehler

Copy link
Copy Markdown
Collaborator

Web meeting 2024-05-08
Pierre will do the merge

@pmai
pmai merged commit a20fa79 into main May 8, 2024
@pmai
pmai deleted the feature/clocks-support branch May 8, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants