[siddheshzz]

Which Issue(s) This PR Fixes(Closes)

Fixes #2584

Brief Description

Removed the useless code from the instantiation as well as defination.

How Did You Test This Change?

cargo clippy --all-targets --all-features --workspace
cargo test --all-features --workspace
cargo fmt --all -- --check

Summary by CodeRabbit

• Refactor
  • Simplified the messaging runtime initialization to streamline message processing.
  • Reduced configuration dependencies for improved performance and maintainability.

[rocketmq-rust-bot]

🔊@siddheshzz 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

[coderabbitai]

Walkthrough

The changes refactor the broker's initialization by updating the BrokerRuntime and SendMessageProcessor implementations. In BrokerRuntime, many fields have been commented out and dependencies removed, while the init_processor method now instantiates processors with fewer parameters. Similarly, the SendMessageProcessor constructor has been simplified by eliminating excess configuration parameters, indicating a streamlining in dependency management across the broker's components.

Changes

File(s)	Change Summary
rocketmq-broker/src/broker_runtime.rs	Commented out several fields in BrokerRuntime and BrokerRuntimeInner; removed configuration and management dependencies; simplified the init_processor method.
rocketmq-broker/src/processor/send_message_processor.rs	Simplified the SendMessageProcessor constructor by removing multiple parameters (e.g., configuration managers and message store); updated inner struct accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant BR as BrokerRuntime
    participant SMP as SendMessageProcessor
    participant TMS as TransactionalMessageService
    participant BRI as BrokerRuntimeInner

    BR->>BR: init_processor()
    BR->>SMP: new(TMS, BRI)
    Note over BR,SMP: Processors initialized with simplified parameters

Loading

Possibly related PRs

• [ISSUE #2526] Remove ConsumerManageProcessor unused code #2529: Refactored processor instantiation and simplified the BrokerRuntime structure by reducing dependencies.
• [ISSUE #2331]🤡Remove PopBufferMergeService useless code🧑‍💻 #2332: Removed similar configuration fields from BrokerRuntime, complementing the current refactoring.
• [ISSUE #2103]💫Add BrokerInner for BrokerRuntime🚀 #2104: Modified the initialization logic of BrokerRuntime affecting the management of message processing components.

Suggested labels

approved

Suggested reviewers

• TeslaRustor
• SpaceXCN
• rocketmq-rust-bot

Poem

Hoppin' through lines, I clear the clutters, 🐇
Unused fields vanish like autumn flutters. 🍂
Code flows now with a simpler beat,
Dependencies light and oh-so neat.
Celebrate changes with a happy leap! 🎉

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbd3528 and c016caa.

📒 Files selected for processing (2)

• rocketmq-broker/src/broker_runtime.rs (0 hunks)
• rocketmq-broker/src/processor/send_message_processor.rs (0 hunks)

💤 Files with no reviewable changes (2)

• rocketmq-broker/src/broker_runtime.rs
• rocketmq-broker/src/processor/send_message_processor.rs

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: build (windows-latest, nightly)
• GitHub Check: build (windows-latest, stable)
• GitHub Check: build (macos-latest, nightly)
• GitHub Check: build (macos-latest, stable)
• GitHub Check: build (ubuntu-latest, nightly)
• GitHub Check: build
• GitHub Check: test
• GitHub Check: build (ubuntu-latest, stable)
• GitHub Check: auto-approve

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.61%. Comparing base (fbd3528) to head (c016caa).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2585      +/-   ##
==========================================
+ Coverage   28.60%   28.61%   +0.01%     
==========================================
  Files         515      515              
  Lines       74594    74566      -28     
==========================================
  Hits        21334    21334              
+ Misses      53260    53232      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rocketmq-rust-bot]

LGTM