Repository navigation
Driver deadlock #22
Description
Describe the bug
With a virtual Xbox 360 controller enabled, programs that poll controller input will be unable to launch. They deadlock attempting to open a handle to the device. This happens with feeder applications as well.
It also prevents any real devices from connecting to or disconnecting from my system.
To Reproduce
I've been unable to consistently reproduce it. It happens fairly frequently, but with no specific steps that I could identify. If applications begin failing to launch with a feeder and Xbox 360 endpoint, however:
- Launch an application that polls for controller input (a game, Uplay, Steam, Battle.net).
- The application will stall or fail to launch.
- Attempt to disable the device with Device Manager/etc, and it will also stall.
- When the feeder is killed, the Xbox 360 endpoint device will enter an error state, displayed in Device Manager.
Expected behavior
Some kind of error handling or error logging. ViGEmClient has error logging, but it doesn't appear to encounter any errors when this deadlock occurs.
Screenshots
I attempted to disable the device, Device Manager stalled, and both the Game Controllers dialog and Battle.net immediately launched. Opening another instance of Device Manager reveals that the device is still enabled:
System details (please complete the following information):
- OS: Windows 10 Pro 1903
- Feeder software: ds4wizard
- Driver Version: 1.14.3.0
Additional context
It very well could be something I'm doing with my feeder, but I've been unable to figure it out.
Activity
nefarius commentedon Aug 12, 2019
Thanks for the report but could you please monitor the situation with the latest driver version as well? What you run is very outdated.
michael-fadely commentedon Aug 12, 2019
...Wow, that IS really old! I missed the latest stable release somehow. Will do!
michael-fadely commentedon Aug 14, 2019
Same issue with latest stable. I will do some experimenting to see if I can narrow down the issue.
MtDewFella commentedon Aug 16, 2019
I have been getting the same problem, wasn't sure if it was steam, glosc or vigem, I assume it's vigem since trying to disable it causes driver manager to freeze up, only fix I have found is to reboot the pc, oddly it never happens during play only after (not all the time only some times)
nefarius commentedon Aug 19, 2019
Dammit 😅
MtDewFella commentedon Aug 20, 2019
I completely uninstalled vigem and glosc, and reinstalled vigem first then glosc and so far I have had no issues, the last time I installed I just installed glosc like normal, which installed vigem (or was supposed to) but when I first used glosc that time I got the couldn't initialize vigem error, I then installed vigem without uninstalling anything, perhaps that caused the issue, I will keep and eye on it
Edit: I can also disable and enable vigem in device manager without issue now
nefarius commentedon Jan 15, 2020
Any news @michael-fadely ?
michael-fadely commentedon Jan 16, 2020
Still exhibiting the exact same behavior, unfortunately. Just having the virtual Xbox 360 device present when attempting to launch an application that uses XInput will sometimes cause this deadlock and require a hard reboot to allow any other physical devices to connect to, or disconnect from, the system.
michael-fadely commentedon Jan 29, 2020
Could this be due to my program's multi-threading? I am using ViGEmClient. I call
vigem_allocandvigem_connect(as well as free and disconnect) on the main thread, butvigem_target_add,vigem_target_x360_register_notification, etc. are called on a secondary thread.michael-fadely commentedon Jan 30, 2020
In my program, everything appears to continue working. I simply unplug the DualShock 4 and it calls
vigem_remove_targetseemingly without error. I will implement some more robust error checking in this instance to be certain.Corrodias commentedon Jan 31, 2020
This seems very similar to a problem I'm experiencing. I'm using DS4Windows, on Windows 10 1909 and the latest version of the driver. After about 3 days of uptime, during which I leave a controller connected by USB at all times, Monster Hunter World will stall on its black startup screen and not proceed to the dev logo, but Special K's overlay is drawn, and Chrome can still start a new, GPU-accelerated video, so it's not a video driver failure. Attempting to "stop" and "start" DS4Windows may appear to work but results in a CPU-spinning thread. Attempting to reboot Windows causes it to hang on "Restarting" for several minutes, then BSOD.
I have not yet narrowed this down to being caused by ViGEmBus. It does seem like a likely culprit, especially after reading this thread. The next time this happens, I'll try disabling the device to see if it hangs, like it does for MtDewFella, and I'll try uninstalling it after the reboot. I will also attempt to get an xperf trace on the shutdown process that includes stacks.
If ViGEmBus does wind up being the culprit, is there anything else I can do to help diagnose this? It seems reliably reproducible for me; I just have to wait 3 days each time.
Corrodias commentedon Jan 31, 2020
In fact, if it's going to do it again, today's the day. I have about 7 or 8 hours before I'm going to commence playing games, at which time I'll be doing the trace and so on if it did deadlock. If you have any advice or suggestions on helping diagnose this, providing them now would be timely.
nefarius commentedon Jan 31, 2020
Make sure kernel memory dumps are enabled and keep the dump file somewhere. It shouldn't be shared publicly but is the best start to get the culprit.
73 remaining items
nefarius commentedon Feb 17, 2021
Even once is too much though, thanks for the feedback nonetheless!
Corrodias commentedon Mar 8, 2021
Pity, I left it running overnight ONE DAY and it happened again. 😆
Is there any thing further I can do to help you diagnose this, other than shipping you my PC? I provided some (unfortunately massive) memory dumps, but evidently those weren't enough on their own.
nefarius commentedon Mar 8, 2021
I'll just scratch everything and start anew 👻
valentyn-l commentedon Jun 26, 2021
I am STILL getting a driver deadlock issue with the 2021 Xbox 360 controller driver. Not an issue with the 2009 driver. This is a problem though because the 2009 driver prevents me from activating Core Isolation in the Device Security settings. Tested this on both Windows 10 and 11 leaked build.
nefarius commentedon Jun 27, 2021
I've pretty much given up on this to be honest. There's simply no resources I or any potential contributor could come up with to tackle this mystery and I'm tired of it and will move on. Sorry.
andrewklamut commentedon Jul 2, 2021
Hi, I'm facing a 100% reproducible issue which might be relevant? The issue is that when I start to use my Xbox 360 controller over Parsec, the host system hangs and must be forced shut down.
Steps:
Using Windows Hyper V, create a Windows 10 VM
Install Parsec on VM guest and VM host
Plug Xbox 360 controller into VM host
Start the Windows 10 VM guest using Hyper-V -> Start (don't do Hyper-V connect) and connect via Parsec
Press any button on the Xbox 360 controller
The VM guest hangs and must be force shut down. If I open Device Manager on the VM guest before step 4, I can see the Xbox Peripheral device is added as step 4 happens, and the Device Manger refreshes very slowly (I see the tree collapse, and then expand).
It kind of seems like a deadlock and I came across this thread and noticed you were stuck, maybe same root cause?
ankomen2 commentedon Aug 26, 2021
I tried the 2009 driver and my pc still freezes when I use my controller. Do you guys have any suggestions?
wingfixer commentedon Jan 1, 2022
Found this topic by accident, realized it was the same issue I had with (as I thought) DS4Windows forever ago, ended up giving up on it and just setting a hotkey to disable the whole thing when not needed.
Appears to be completely random, could run for hours or days before it happens, so people that don't leave their PC running for long may be susceptible but will never notice it.
nefarius commentedon Jan 1, 2022
It will be solved by the rewrite I am working on in the dev dungeon ⚒️
nefarius commentedon Aug 8, 2022
Time to close this. Can't fix something I can not replicate. Sorry.
gjmv commentedon Aug 8, 2022
I have the driver installed again in windows 11, in PC and laptop, and never again get deadlock.
nefarius commentedon Aug 8, 2022
This issue isn't about a bluescreen.
gjmv commentedon Aug 8, 2022
Sorry, deadlock
starjet commentedon Mar 28, 2023
I know this repo is no longer being updated in favour of whatever new one nefarius is working on, but I still want to comment on this
I faced this problem myself and finally managed to isolate the issue to the controller
This was pretty hard to troubleshoot as there's so little info on the web about this problem. As someone above said, only the few of us that keep our PCs running for a long time are bound to notice this most likely
Anyway, two things:
What drove me towards this being related to the Xbox controller driver is this post in Microsoft Answers: https://answers.microsoft.com/en-us/windows/forum/all/video-games-wont-launch-problems-with-restarting/6b139719-470d-4658-860c-68f3224e0a40
This suggests that the problem could be tied to the basic Xbox 360 controller driver itself, and not something that originates in Vigembus (Though Vigembus somehow likely exacerbates the problem, leading to the driver being stuck even after you pull out the controller)
I will be following the recommendation to downgrade to the 2009 Xbox 360 controller driver. Will report back if I face this problem again. Though it's going to be hard to tell if it's fixed per se, as this problem only pops up very randomly (Sometimes it may happen twice in a week, but sometimes it may not happen for three to four months at a stretch)