Repository navigation
Add devcontainer config - #295
Merged
Merged
Conversation
Totto16
requested changes
Jun 4, 2024
Collaborator
|
I improved a few things, that would be too complicated to tell you, so I just did them myself: general:
Dockerfile:
I used a newer image in the Dockerfile, since there is no reason to use a specific 20.x.y version, we just want to use the latest 20.x.y version and also there is no reason not using the latest alpine image I also tested this locally and it seems to work as expected with these changes. I'll wait until merging this, so that you can say, if something I did is not the best for a devcontainer. From my side it's approved. And thank you for your contributiion ❤️ |
Totto16
approved these changes
Jun 4, 2024
- move Dockerfile to not clutter the root dir - add suggested extensions to customizations - add postCreateCommand to install packages after create - use better image in Dockerfile - collapse multiple RUN commands into one, to reduce image layers - install yarn in Dockerfile, otherwise the user will be prompted about that later - settings format them in alphabetical order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This should help make it easier to build and install the extension using VSCode (or any other devcontainer-supporting IDE). The gnome shell extensions dir is mounted directly at the corresponding location inside the container so the install command should work.
Checklist