Skip to content

Add devcontainer config - #295

Merged
Totto16 merged 5 commits into
oae:masterfrom
forabi:master
Jun 8, 2024
Merged

Totto16 merged 5 commits into
oae:masterfrom
forabi:master

Conversation

@forabi

@forabi forabi commented Jun 4, 2024

Copy link
Copy Markdown
Contributor

Pull Request Template

Description

This should help make it easier to build and install the extension using VSCode (or any other devcontainer-supporting IDE). The gnome shell extensions dir is mounted directly at the corresponding location inside the container so the install command should work.

Checklist

  • My code follows the style guidelines of this project
  • My commits follow the commit standards of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

@Totto16 Totto16 self-assigned this Jun 4, 2024
@Totto16 Totto16 added the enhancement New feature or request label Jun 4, 2024
Comment thread .devcontainer/devcontainer.json Resolved
Comment thread Dockerfile Resolved
Comment thread Dockerfile Resolved
@forabi
forabi requested a review from Totto16 June 4, 2024 12:24
@Totto16

Totto16 commented Jun 4, 2024 •

Copy link
Copy Markdown
Collaborator

I improved a few things, that would be too complicated to tell you, so I just did them myself:

general:

  • move Dockerfile to not clutter the root dir
  • add suggested extensions to customizations
  • add postCreateCommand to install packages after create

Dockerfile:

  • use better image in Dockerfile
  • collapse multiple RUN commands into one, to reduce image layers
  • install yarn in Dockerfile, otherwise the user will be prompted about that later

I used a newer image in the Dockerfile, since there is no reason to use a specific 20.x.y version, we just want to use the latest 20.x.y version and also there is no reason not using the latest alpine image

I also tested this locally and it seems to work as expected with these changes.

I'll wait until merging this, so that you can say, if something I did is not the best for a devcontainer. From my side it's approved.

And thank you for your contributiion ❤️

forabi and others added 5 commits June 5, 2024 01:44
- move Dockerfile to not clutter the root dir
- add suggested extensions to customizations
- add postCreateCommand to install packages after create
- use better image in Dockerfile
-  collapse multiple RUN commands into one, to reduce image layers
-  install yarn in Dockerfile, otherwise the user will be prompted about that later
- settings format them in alphabetical order
@Totto16
Totto16 merged commit 9b068d7 into oae:master Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants