Skip to content

Fix stack smash crashes on Linux - #493

Merged
RytoEX merged 1 commit into
obsproject:masterfrom
hoshinolina:fix-stack-smash-crashes
Aug 20, 2025
Merged

RytoEX merged 1 commit into
obsproject:masterfrom
hoshinolina:fix-stack-smash-crashes

Conversation

@hoshinolina

Copy link
Copy Markdown
Contributor

Description

See: chromiumembedded/cef#3912
Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=2379591

How Has This Been Tested?

Local test build

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX

RytoEX commented Jul 28, 2025

Copy link
Copy Markdown
Member

cc @tytan652 @GeorgesStavracas

Is this fixing an issue currently in the wild? Want to gauge whether this needs to land in a 31.1.x release or if it can wait until a future major/minor release.

@tytan652

tytan652 commented Jul 29, 2025 •

Copy link
Copy Markdown
Contributor

It's not exclusive to 31.1 (earlier version have the issue) and will require to backport changes to CEF 127 to have NO_STACK_PROTECTOR defined and enable the decoration.

So in my opinion it can wait until a future major/minor release.

@hoshinolina

Copy link
Copy Markdown
Contributor Author

The main issue is noise for distros that have coredumps/reporting (like Fedora). Other than that it seems to be harmless since the crashes only happen on process exit.

For the fedora RPMs I will push this patch in so it's fixed there, since otherwise users will get abrt popups and file bugs with us (I already got one). I can't say about the effect for other distros or through the official Flatpak. If this has been going on for a while and nobody has complained about it yet, maybe it's fine to wait?

@WizardCM WizardCM added the kind/bug Categorizes issue or PR as related to a bug. label Aug 16, 2025
@RytoEX
RytoEX merged commit 0e38358 into obsproject:master Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants