[prgmitchell]

Description

Send the monitor signal before reusing its calldata buffer for the compatibility signal.

Motivation and Context

Saw a bug report and verified the same behavior myself on Windows. stack was being reused causing monitor to always be false.

This fixes #13821

How Has This Been Tested?

Tested enabling/disabling monitoring with hotkeys, the UI now updates live in both the audio mixer and advanced audio properties windows.

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have read the contributing document.
• My code has been run through clang-format.
• My code follows the project's style guidelines
• My code is not on the master branch.
• My code has been tested.
• All commit messages are properly formatted and commits squashed where appropriate.
• I have included updates to all appropriate documentation.

[tiberium-v]

That PR fix it also for me on the linux flatpak side. I also tested it with the same hotkey for multiple source and the icon state update flawless over the board.

Since I opened the issue, I want to make a commit here, that it fix it.

[PatTheMav]

Please amend the commit description properly explaining why this is the correct fix (per our contribution guidelines).

At a glance I could only figure that out guessing that stack is being overwritten with new initialised data by the second call to calldata_init_fixed, but this is precisely what the commit message should point out.

If that's indeed the case, the fix is correct otherwise.

[prgmitchell]

Please amend the commit description properly explaining why this is the correct fix (per our contribution guidelines).

At a glance I could only figure that out guessing that stack is being overwritten with new initialised data by the second call to calldata_init_fixed, but this is precisely what the commit message should point out.

If that's indeed the case, the fix is correct otherwise.

All set, sorry about that I originally took a different approach before Warchamps review comment and didn't properly update the commit description when I made that change.