Repository navigation
updater: Retain legacy module path support - #13939
Merged
Merged
Conversation
github-project-automation
Bot
moved this to Ready For Review
in Current Release Tracker (33.0)
PatTheMav
reviewed
Sep 28, 2026
RytoEX
requested changes
Sep 28, 2026
RytoEX
left a comment
RytoEX
left a comment
Member
There was a problem hiding this comment.
The changes here are correct, though it does not address the game capture hook file paths as previously mentioned off-thread.
RytoEX
reviewed
Sep 29, 2026
The updater itself is distributed and updated for all versions of OBS for which updates are still available. As such, it needs to be aware of the legacy plugin location for versions before v33 and the new location for v33 onwards. When checking if the browser plugin exists, check both locations. When installing the virtual cam, we reference the manifest for the version we are updating to and use the appropriate location.
Warchamp7
force-pushed
the
updater-v33-fixes
branch
2 times, most recently
from
September 29, 2026 20:19
602b3c5 to
003fce6
Compare
RytoEX
added
kind/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When checking if the browser plugin is installed, check the legacy plugin location as well as the new core location from v33 onwards.
When installing the virtual cam, check the manifest for the version we are updating to and use the appropriate location based on that.
Motivation and Context
The updater itself is distributed and updated for all versions of OBS for which updates are still available. As such, it needs to be aware of the legacy plugin location for versions before v33 and the new location for v33 onwards.
When checking if the browser plugin exists, check both locations.
When installing the virtual cam, we reference the manifest for the version we are updating to and use the appropriate location.
How Has This Been Tested?
It has not.
Types of changes
Checklist: