Repository navigation
frontend: Fix plugin restart prompt stale data - #14112
Merged
Merged
Conversation
Warchamp7
added
kind/bug
github-project-automation
Bot
moved this to Ready For Review
in Current Release Tracker (33.0)
Warchamp7
moved this from Ready For Review
to Ready For Merge
in Current Release Tracker (33.0)
RytoEX
added
the
release-note/fix
FiniteSingularity
approved these changes
Oct 29, 2026
FiniteSingularity
left a comment
FiniteSingularity
left a comment
Contributor
There was a problem hiding this comment.
Code change looks good.
Tested it on Windows, and all is working great. LGTM.
|
Fixes: #14110 for those keeping track |
RytoEX
approved these changes
Oct 29, 2026
github-project-automation
Bot
moved this from Ready For Merge
to Merged
in Current Release Tracker (33.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Plugin Manager not prompting for save after a change until the dialog is re-opened.
Motivation and Context
#14008 updated the window to not use a pointer back to the actual modules data in the UI rows, but this also meant the local
Entryobjects only had theirenablestate set when the dialog was opened, not when the value changed.Fixes #14110.
How Has This Been Tested?
Toggled modules on/off. Ensured the restart notice and prompt appeared when changes were made. Ensured those changes were persisted to the modules.json
Types of changes
Checklist: