⚽ Live Match: oneapi src/level zero/pull/

nrspruit · 2024-10-25T00:36:35Z

Static Loader Support.

This support has a few conditions:

zes/ze driver split is not supported without this version of the loader so backwards compatibility for different lists of drivers for ze/zes init is not supported if using the static lib due to needing to modify the loader's context. zes/ze driver list will be the same.
As of this version of the loader, all symbols read between the static loader and the dynamic loader must remain ABI compatible ie all apis exported in source/loader/ze_loader_api.h now must be abi compatible.
The oldest dynamic loader supported is v1.15.17

lisanna-dettwyler

Just a couple small comments from looking at it briefly

ilya-lavrenov · 2024-11-20T07:54:23Z

Issue #141

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

- Added support for older dii tables such that the version of the apis supported by that dynamic loader are requested and not newer versions. - Added check for backwards compatability for older init apis. Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

… loader build Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

…build Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

rwmcguir · 2025-02-20T20:13:15Z

Looks good to me, as I have seen the testing output. Debating on if we need to increment minor here as part of this commit since it is a decent size feature add-on.

EDIT... I see this was just added..

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

Added possibility to build this library statically that was implemented upstream in oneapi-src/level-zero#224 Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>

nrspruit requested review from Jemale, lisanna-dettwyler and rwmcguir October 25, 2024 00:36

lisanna-dettwyler reviewed Oct 25, 2024

View reviewed changes

Comment thread source/CMakeLists.txt Resolved

Comment thread source/lib/ze_lib.cpp Resolved

nrspruit force-pushed the static_loader branch from dcca4f4 to 222da8e Compare November 15, 2024 19:34

nrspruit changed the title ~~[DO_NOT_MERGE] Static L0 Loader Support~~ Static L0 Loader Support Nov 15, 2024

nrspruit requested a review from aravindksg November 15, 2024 19:59

nrspruit force-pushed the static_loader branch 2 times, most recently from 62860db to 0397704 Compare November 15, 2024 21:40

nrspruit force-pushed the static_loader branch from 0397704 to a9842e3 Compare December 10, 2024 18:51

nrspruit force-pushed the static_loader branch 2 times, most recently from 575a758 to faaa9e8 Compare January 27, 2025 19:30

nrspruit marked this pull request as ready for review January 27, 2025 22:10

rwmcguir reviewed Jan 29, 2025

View reviewed changes

Comment thread source/lib/ze_lib.h Resolved

rwmcguir reviewed Jan 29, 2025

View reviewed changes

Comment thread source/lib/ze_lib.h Resolved

nrspruit force-pushed the static_loader branch 4 times, most recently from aec89b8 to 399cd15 Compare February 11, 2025 21:30

nrspruit force-pushed the static_loader branch 2 times, most recently from 399cd15 to dc17e65 Compare February 14, 2025 21:46

nrspruit added 8 commits February 19, 2025 10:15

Static Loader Support

9e60ae1

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

handle older loader

9904e6c

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

Add workflows for static builds

4d0be14

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

Fix windows build for dllmain

b162d53

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

Fix windows tests build and multi workflow

b96dc38

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

Update Logging and Version check with more details and fix for static…

ffeeb5f

… loader build Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

Add scripts updates

995b875

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

nrspruit added 3 commits February 19, 2025 10:15

Fix zelLoaderTranslateHandle for static linkage use

228c8fd

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

fix lib context init and log include

8cf53d4

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

Fix the loader context init to be static for static lib

59b3c48

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

nrspruit force-pushed the static_loader branch from dc17e65 to bebac0d Compare February 19, 2025 18:32

Force dynamic init of L0 loader

ab4fcf5

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

nrspruit force-pushed the static_loader branch from bebac0d to ab4fcf5 Compare February 19, 2025 18:39

nrspruit added 2 commits February 19, 2025 11:09

handle if zeInit is called for forced init

9bc87d1

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

Fix shared context symbol usage and remove loader/layers from static …

e0a776e

…build Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

nrspruit force-pushed the static_loader branch from 93d7aee to e0a776e Compare February 20, 2025 03:10

Fix build quick linux workflow

4a94021

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

nrspruit force-pushed the static_loader branch from e4e0dd1 to 4a94021 Compare February 20, 2025 03:25

Allow debug env path for static loader init

55408cc

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

nrspruit force-pushed the static_loader branch from 9d1d945 to c37f0b3 Compare February 20, 2025 03:47

fix static worklflow env

98f3dbc

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

nrspruit force-pushed the static_loader branch 4 times, most recently from 06a32ba to ad041c7 Compare February 20, 2025 16:05

Added debug print for static loader path

7ad5a62

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

nrspruit force-pushed the static_loader branch from ad041c7 to 7ad5a62 Compare February 20, 2025 16:12

Init the loader context after successfully init of the driver

a2ff82c

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

nrspruit force-pushed the static_loader branch from a6dda55 to 50fd283 Compare February 20, 2025 20:12

Update to v1.21.0 along with documentation on the static loader

f9b2f31

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>

nrspruit force-pushed the static_loader branch from 50fd283 to f9b2f31 Compare February 20, 2025 20:15

rwmcguir approved these changes Feb 20, 2025

View reviewed changes

nrspruit merged commit 51dd3d8 into oneapi-src:master Feb 20, 2025

AenBleidd mentioned this pull request Jan 20, 2026

[level-zero] update to 1.26.3 microsoft/vcpkg#49509

Merged

5 of 7 tasks

Navigation Menu

Repository navigation

Static L0 Loader Support - #224

Static L0 Loader Support#224
nrspruit merged 22 commits into
oneapi-src:masterfrom
nrspruit:static_loader

nrspruit commented Oct 25, 2024 •

edited

Loading

Uh oh!

lisanna-dettwyler left a comment

Uh oh!

Uh oh!

Uh oh!

ilya-lavrenov commented Nov 20, 2024

Uh oh!

Uh oh!

Uh oh!

rwmcguir commented Feb 20, 2025 •

edited

Loading

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

nrspruit commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lisanna-dettwyler left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ilya-lavrenov commented Nov 20, 2024

Uh oh!

Uh oh!

Uh oh!

rwmcguir commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nrspruit commented Oct 25, 2024 •

edited

Loading

rwmcguir commented Feb 20, 2025 •

edited

Loading