Repository navigation
Support for Sorting Drivers based on the devices provided - #259
Merged
Merged
Conversation
- Added support for reporting drivers sorted based on the types of
devices returned.
- By default, drivers will be sorted such that the ordering will be:
- Drivers with Discrete GPUs only
- Drivers with Discrete and Integrated GPUs
- Drivers with Integrated GPUs
- Drivers with Mixed Devices Types (ie GPU + NPU)
- Drivers with Non GPU Devices Only
- If ZE_ENABLE_PCI_ID_DEVICE_ORDER is set, then the following ordering
is provided:
- Drivers with Integrated GPUs
- Drivers with Discrete and Integrated GPUs
- Drivers with Discrete GPUs only
- Drivers with Mixed Devices Types (ie GPU + NPU)
- Drivers with Non GPU Devices Only
- Expanded the zello_world sample to test both init paths for easy
prototyping.
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
force-pushed
the
driver_sorting
branch
from
January 14, 2025 23:38
41e098f to
5a4efe4
Compare
nrspruit
marked this pull request as ready for review
January 15, 2025 14:36
rwmcguir
reviewed
Jan 16, 2025
rwmcguir
reviewed
Jan 16, 2025
rwmcguir
previously approved these changes
Jan 16, 2025
rwmcguir
left a comment
rwmcguir
left a comment
Contributor
There was a problem hiding this comment.
Other than silly comments, I don't have any commentary on the ordering mechanism. Seems simple and easily modifiable via the ENUM, which is ... well pretty cool.
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
force-pushed
the
driver_sorting
branch
from
January 16, 2025 22:08
db1ffb7 to
a0b4cdb
Compare
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
rwmcguir
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for reporting drivers sorted based on the types of devices returned.
By default, drivers will be sorted such that the ordering will be:
If ZE_ENABLE_PCI_ID_DEVICE_ORDER is set, then the following ordering is provided:
Expanded the zello_world sample to test both init paths for easy prototyping.