Repository navigation
Add configurable path_prefix parameter - #6674
Merged
Merged
Conversation
Pigueiras
requested review from
KarstenSchnitter,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
March 25, 2026 21:00
dlvenable
reviewed
Mar 30, 2026
dlvenable
left a comment
dlvenable
left a comment
Member
There was a problem hiding this comment.
Thank you @Pigueiras for this contribution!
Pigueiras
changed the title
Contributor
Author
No problem :) I changed the parameter to |
divbok
previously approved these changes
May 6, 2026
Davidding4718
left a comment
Davidding4718
left a comment
Contributor
There was a problem hiding this comment.
Please address a minor change for ConnectionConfigurationTests.java
Introduce an optional `path_prefix` sink parameter to support OpenSearch instances served behind a reverse proxy under a custom subdirectory. Resolves opensearch-project#6654 Signed-off-by: Luis Pigueiras <luis.pigueiras@cern.ch>
There was a problem hiding this comment.
Pull request overview
Adds a new optional path_prefix configuration parameter to the OpenSearch sink so it can communicate with OpenSearch clusters exposed behind a reverse proxy under a sub-path (e.g., /os).
Changes:
- Added
path_prefixtoOpenSearchSinkConfigand propagated it intoConnectionConfiguration. - Configured the underlying
RestClientBuilderto use the configured path prefix. - Added unit tests and test YAML configuration coverage for parsing/reading
path_prefix.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| data-prepper-plugins/opensearch/src/main/java/org/opensearch/dataprepper/plugins/sink/opensearch/ConnectionConfiguration.java | Threads path_prefix through connection config and applies it to the REST client builder. |
| data-prepper-plugins/opensearch/src/main/java/org/opensearch/dataprepper/plugins/sink/opensearch/configuration/OpenSearchSinkConfig.java | Introduces the new path_prefix sink parameter for configuration parsing. |
| data-prepper-plugins/opensearch/src/test/java/org/opensearch/dataprepper/plugins/sink/opensearch/ConnectionConfigurationTests.java | Adds coverage for default/null and configured path_prefix in connection configuration. |
| data-prepper-plugins/opensearch/src/test/java/org/opensearch/dataprepper/plugins/sink/opensearch/OpenSearchSinkConfigurationTests.java | Adds YAML parsing coverage for path_prefix. |
| data-prepper-plugins/opensearch/src/test/resources/open-search-sink-configurations.yaml | Adds a sample pipeline config including path_prefix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
298
to
301
| if (serverlessOptions != null) { | ||
| builder = builder.withServerlessNetworkPolicyName(serverlessOptions.getNetworkPolicyName()) | ||
| .withServerlessCollectionName(serverlessOptions.getCollectionName()) | ||
| .withServerlessVpceId(serverlessOptions.getVpceId()); |
Comment on lines
659
to
660
| private String password; | ||
| private String apitoken; |
dlvenable
approved these changes
Jun 4, 2026
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 1, 2026
Introduce an optional `path_prefix` sink parameter to support OpenSearch instances served behind a reverse proxy under a custom subdirectory. Resolves opensearch-project#6654 Signed-off-by: Luis Pigueiras <luis.pigueiras@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce an optional
path_prefixsink parameter to support OpenSearch instances served behind a reverse proxy under a custom subdirectory.Issues Resolved
Resolves #6654
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.