Skip to content

Add SPDX license tags to build system files - #18077

Closed
robn wants to merge 2 commits into
openzfs:masterfrom
robn:build-license-tags
Closed

Add SPDX license tags to build system files#18077
robn wants to merge 2 commits into
openzfs:masterfrom
robn:build-license-tags

Conversation

@robn

@robn robn commented Dec 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation and Context

#18074 prompted me to look into exactly what the deal is with licensing around autoconf extensions/macros (tl;dr: no big deal). Since I was in there thinking about licenses anyway, I went through and added the tags

Closes #18074.

Description

Build files are *.am, *.ac and *.m4. Almost all are CDDL-1.0, as you'd expect.

Most third-party macros are from the autoconf archive, and are under FSF "Permissive" or "Unlimited" licenses (FSFAP and FSFULLR).

The other two are regular GPL licenses with "exceptions". The SPDX identifier format actually has this whole grammar for expressing combinations and add-ons, but we don't need most of it, so I've just hardcoded those two as specific long strings in spdxcheck.pl.

How Has This Been Tested?

Compile checked on Linux and FreeBSD for completeness, but since it's entirely adding comments I wouldn't expect anything.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@robn robn mentioned this pull request Dec 21, 2025
Closed
@behlendorf
behlendorf self-requested a review December 22, 2025 23:01
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 22, 2025
@robn
robn force-pushed the build-license-tags branch from ca22879 to afcee41 Compare December 24, 2025 03:13
robn added 2 commits January 5, 2026 09:34
@robn
build: add SPDX license tags to build system files
fff53ac 
Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <robn@despairlabs.com>
@robn
spdxcheck: enforce SPDX license tags on build system files
edb867c 
Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <robn@despairlabs.com>
@robn
robn force-pushed the build-license-tags branch from afcee41 to edb867c Compare January 4, 2026 22:35
behlendorf
behlendorf approved these changes Jan 5, 2026
View reviewed changes

@behlendorf behlendorf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for making this clear and updating the spdxcheck accordingly.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jan 5, 2026
@behlendorf behlendorf closed this in 85391ee Jan 8, 2026
behlendorf pushed a commit that referenced this pull request Jan 8, 2026
@robn @behlendorf
spdxcheck: enforce SPDX license tags on build system files
1051c3d 
Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes #18077
@robn
robn deleted the build-license-tags branch January 9, 2026 02:36
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Jan 31, 2026
@robn @mcmilk
build: add SPDX license tags to build system files
32f5b53 
Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18077
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Jan 31, 2026
@robn @mcmilk
spdxcheck: enforce SPDX license tags on build system files
b9e307f 
Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18077
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Feb 5, 2026
@robn @lundman
build: add SPDX license tags to build system files
be1decd 
Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18077
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Feb 5, 2026
@robn @lundman
spdxcheck: enforce SPDX license tags on build system files
2a1517b 
Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18077
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
@robn @lundman
build: add SPDX license tags to build system files
bd0feb7 
Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18077
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
@robn @lundman
spdxcheck: enforce SPDX license tags on build system files
145e8dc 
Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18077
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
@robn @lundman
build: add SPDX license tags to build system files
988ba3f 
Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18077
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
@robn @lundman
spdxcheck: enforce SPDX license tags on build system files
073a9b3 
Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18077
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 23, 2026
@robn @tonyhutter
build: add SPDX license tags to build system files
609828f 
Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18077
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Apr 23, 2026
@robn @tonyhutter
spdxcheck: enforce SPDX license tags on build system files
93ee61a 
Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18077
tonyhutter pushed a commit that referenced this pull request May 12, 2026
@robn @tonyhutter
build: add SPDX license tags to build system files
fc44c73 
Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes #18077
tonyhutter pushed a commit that referenced this pull request May 12, 2026
@robn @tonyhutter
spdxcheck: enforce SPDX license tags on build system files
4234660 
Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes #18077
bugclerk pushed a commit to truenas/zfs that referenced this pull request May 14, 2026
@robn @bugclerk
build: add SPDX license tags to build system files
684f3ac 
Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18077
(cherry picked from commit fc44c73)
bugclerk pushed a commit to truenas/zfs that referenced this pull request May 14, 2026
@robn @bugclerk
spdxcheck: enforce SPDX license tags on build system files
4f90643 
Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18077
(cherry picked from commit 4234660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behlendorf behlendorf behlendorf approved these changes
@tonyhutter tonyhutter tonyhutter approved these changes

Assignees

No one assigned

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

parallel kABI configure checks and licensing

3 participants

@robn @behlendorf @tonyhutter