Repository navigation
zpl_super: prefer "new" mount API when available - #18260
Merged
Merged
Conversation
This API has been available since kernel 5.2, and having it available (almost) everywhere should give us a lot more flexibility for mount management in the future. Sponsored-by: TrueNAS Signed-off-by: Rob Norris <rob.norris@truenas.com>
tonyhutter
approved these changes
Feb 25, 2026
behlendorf
approved these changes
Feb 25, 2026
tonyhutter
pushed a commit
that referenced
this pull request
May 12, 2026
This API has been available since kernel 5.2, and having it available (almost) everywhere should give us a lot more flexibility for mount management in the future. Sponsored-by: TrueNAS Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rob Norris <rob.norris@truenas.com> Closes #18260
tonyhutter
pushed a commit
that referenced
this pull request
May 12, 2026
This API has been available since kernel 5.2, and having it available (almost) everywhere should give us a lot more flexibility for mount management in the future. Sponsored-by: TrueNAS Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rob Norris <rob.norris@truenas.com> Closes #18260
bugclerk
pushed a commit
to truenas/zfs
that referenced
this pull request
May 14, 2026
This API has been available since kernel 5.2, and having it available (almost) everywhere should give us a lot more flexibility for mount management in the future. Sponsored-by: TrueNAS Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rob Norris <rob.norris@truenas.com> Closes openzfs#18260 (cherry picked from commit 1ace2bf)
lundman
pushed a commit
to openzfsonosx/openzfs-fork
that referenced
this pull request
Jul 30, 2026
This API has been available since kernel 5.2, and having it available (almost) everywhere should give us a lot more flexibility for mount management in the future. Sponsored-by: TrueNAS Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rob Norris <rob.norris@truenas.com> Closes openzfs#18260
pull Bot
pushed a commit
to A-Archives-and-Forks/openzfs
that referenced
this pull request
Sep 26, 2026
This API has been available since kernel 5.2, and having it available (almost) everywhere should give us a lot more flexibility for mount management in the future. Sponsored-by: TrueNAS Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rob Norris <rob.norris@truenas.com> Closes openzfs#18260
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Sponsors: TrueNAS]
Motivation and Context
#18216 added shims to wire our old-style mount callbacks to the newer kernel mount API, since the old API was removed in 7.0. I'm keen to refactor a lot of our old mount handing to use the new mount API, but first I want to see what effect this has on the versions we support. Easiest way to do that is to throw CI at it and see what happens.
Description
Effectively inverting the check. Rather then checking for the presence of the mount callbacks, we instead check for the present of
fs_context, which should make the new code compile back to 5.2.How Has This Been Tested?
Compile and sanity run on 4.19.325 (old), 5.10.240, 6.18.9 and 7.0-rc1 (new).
FS_HAVE_CONTEXTnot defined on 4.19, defined on the others.If CI passes, I would like to see this merged to master so we have until 2.5 to see if there's any fallout. I would suggest not backporting it to 2.4, even if the Linux 7.0 support patches do land there.
Types of changes
Checklist:
Signed-off-by.