Skip to content

linux/super: require fs_context, remove support for old mount API - #18339

Closed
robn wants to merge 5 commits into
openzfs:masterfrom
robn:always-fs-context
Closed

linux/super: require fs_context, remove support for old mount API#18339
robn wants to merge 5 commits into
openzfs:masterfrom
robn:always-fs-context

Conversation

@robn

@robn robn commented Mar 16, 2026

Copy link
Copy Markdown
Member

[Sponsors: TrueNAS]

Motivation and Context

Follow #18295, we now don't have to support anything that doesn't have the "new" mount API, so we can start to remove it.

This is the first part, just removing the old API interface and flattening out some of the code.

Description

  • error out if ZFS_AC_KERNEL_FS_CONTEXT fails
  • remove the old mount/remount entry points gated by HAVE_FS_CONTEXT
  • flatten the series of functions involved in mount and remount into zpl_get_tree() and `zpl_reconfigure()

Note that this PR doesn't go beyond zpl_super.c; zfs_domount() and zfs_remount() are both ripe for further cleanup but are exported, so need a little more though & study first.

How Has This Been Tested?

Full ZTS run on 6.12.63 completed succesfully. Compile checked on 6.18.12, 5.10.24 and 4.18.0-553.109.1.el8_10.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

robn added 5 commits March 17, 2026 10:03
@robn
config: refuse to build without fs_context
01a3e13 
Sponsored-by: TrueNAS
Signed-off-by: Rob Norris <rob.norris@truenas.com>
@robn
linux/super: remove support for old mount API
7e97f21 
Removing the HAVE_FS_CONTEXT gates and anything that would be used if it
wasn't set.

Sponsored-by: TrueNAS
Signed-off-by: Rob Norris <rob.norris@truenas.com>
@robn
linux/super: flatten mount/remount into get_tree/reconfigure
9616a7c 
With the old API gone, there's no need to massage new-style calls into
its shape and call another function; we can just make those handlers
work directly.

Sponsored-by: TrueNAS
Signed-off-by: Rob Norris <rob.norris@truenas.com>
@robn
linux/super: flatten zpl_mount_impl into zpl_get_tree
4d1dfbb 
Target of opportunity; with no other callers, there's no need for it to
be a static function.

Sponsored-by: TrueNAS
Signed-off-by: Rob Norris <rob.norris@truenas.com>
@robn
linux/super: flatten zpl_fill_super into zpl_get_tree
24d287f 
Target of opportunity; with no other callers, there's no need for it to
be a static function.

Sponsored-by: TrueNAS
Signed-off-by: Rob Norris <rob.norris@truenas.com>
@robn robn changed the title linux/super: require fs_context, remove support for old mount API linux/super: require fs_context, remove support for old mount API Mar 16, 2026
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Mar 18, 2026
behlendorf pushed a commit that referenced this pull request Mar 18, 2026
@robn @behlendorf
linux/super: remove support for old mount API
f828aeb 
Removing the HAVE_FS_CONTEXT gates and anything that would be used if it
wasn't set.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes #18339
behlendorf pushed a commit that referenced this pull request Mar 18, 2026
@robn @behlendorf
linux/super: flatten mount/remount into get_tree/reconfigure
5ebb9ff 
With the old API gone, there's no need to massage new-style calls into
its shape and call another function; we can just make those handlers
work directly.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes #18339
behlendorf pushed a commit that referenced this pull request Mar 18, 2026
@robn @behlendorf
linux/super: flatten zpl_mount_impl into zpl_get_tree
96a0b20 
Target of opportunity; with no other callers, there's no need for it to
be a static function.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes #18339
behlendorf pushed a commit that referenced this pull request Mar 18, 2026
@robn @behlendorf
linux/super: flatten zpl_fill_super into zpl_get_tree
3ee08ab 
Target of opportunity; with no other callers, there's no need for it to
be a static function.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes #18339
@robn robn mentioned this pull request Mar 27, 2026
Merged
4 of 14 tasks
tonyhutter pushed a commit that referenced this pull request May 12, 2026
@robn @tonyhutter
config: refuse to build without fs_context
a4ba3fd 
Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes #18339
tonyhutter pushed a commit that referenced this pull request May 12, 2026
@robn @tonyhutter
linux/super: remove support for old mount API
7bd9c04 
Removing the HAVE_FS_CONTEXT gates and anything that would be used if it
wasn't set.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes #18339
tonyhutter pushed a commit that referenced this pull request May 12, 2026
@robn @tonyhutter
linux/super: flatten mount/remount into get_tree/reconfigure
92a6642 
With the old API gone, there's no need to massage new-style calls into
its shape and call another function; we can just make those handlers
work directly.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes #18339
tonyhutter pushed a commit that referenced this pull request May 12, 2026
@robn @tonyhutter
linux/super: flatten zpl_mount_impl into zpl_get_tree
b9dc134 
Target of opportunity; with no other callers, there's no need for it to
be a static function.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes #18339
tonyhutter pushed a commit that referenced this pull request May 12, 2026
@robn @tonyhutter
linux/super: flatten zpl_fill_super into zpl_get_tree
08ead4f 
Target of opportunity; with no other callers, there's no need for it to
be a static function.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes #18339
tonyhutter pushed a commit that referenced this pull request May 12, 2026
@robn @tonyhutter
config: refuse to build without fs_context
bec56a4 
Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes #18339
tonyhutter pushed a commit that referenced this pull request May 12, 2026
@robn @tonyhutter
linux/super: remove support for old mount API
0edbfbf 
Removing the HAVE_FS_CONTEXT gates and anything that would be used if it
wasn't set.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes #18339
tonyhutter pushed a commit that referenced this pull request May 12, 2026
@robn @tonyhutter
linux/super: flatten mount/remount into get_tree/reconfigure
7c3f75a 
With the old API gone, there's no need to massage new-style calls into
its shape and call another function; we can just make those handlers
work directly.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes #18339
tonyhutter pushed a commit that referenced this pull request May 12, 2026
@robn @tonyhutter
linux/super: flatten zpl_mount_impl into zpl_get_tree
04692b2 
Target of opportunity; with no other callers, there's no need for it to
be a static function.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes #18339
tonyhutter pushed a commit that referenced this pull request May 12, 2026
@robn @tonyhutter
linux/super: flatten zpl_fill_super into zpl_get_tree
20b8936 
Target of opportunity; with no other callers, there's no need for it to
be a static function.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes #18339
@robn
robn deleted the always-fs-context branch June 14, 2026 05:36
jaminmc pushed a commit to jaminmc/zfsonlinux that referenced this pull request Jun 16, 2026
Stoiko Ivanov @ThomasLamprecht
update submodule to 2.4.2 and refresh patches
225081b 
mostly drop all patches that are now included in 2.4.2 (most of those
were the 7.0 compatibility fixes).

The changes between 2.4.1 and 2.4.2 are kernel-compat patches (up to
7.1[0]), some bugfixes, a few patches addressing removal of the old
mount-api [1,2], rework of tests and CI. Nothing stood out as too
scary.

Minimally tested on 2 VMs with replication (also including the recent
changes of supporting sending encrypted datasets with
--no-preserve-encryption).

[0] openzfs/zfs#18471
[1] openzfs/zfs#18339
[2] openzfs/zfs#18377

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Link: https://lore.proxmox.com/20260513160819.2000176-1-s.ivanov@proxmox.com
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Jul 30, 2026
@robn @lundman
config: refuse to build without fs_context
37168ef 
Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes openzfs#18339
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Jul 30, 2026
@robn @lundman
linux/super: remove support for old mount API
38165a4 
Removing the HAVE_FS_CONTEXT gates and anything that would be used if it
wasn't set.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes openzfs#18339
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Jul 30, 2026
@robn @lundman
linux/super: flatten mount/remount into get_tree/reconfigure
f051800 
With the old API gone, there's no need to massage new-style calls into
its shape and call another function; we can just make those handlers
work directly.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes openzfs#18339
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Jul 30, 2026
@robn @lundman
linux/super: flatten zpl_mount_impl into zpl_get_tree
88307b8 
Target of opportunity; with no other callers, there's no need for it to
be a static function.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes openzfs#18339
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Jul 30, 2026
@robn @lundman
linux/super: flatten zpl_fill_super into zpl_get_tree
018e1ba 
Target of opportunity; with no other callers, there's no need for it to
be a static function.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes openzfs#18339
pull Bot pushed a commit to A-Archives-and-Forks/openzfs that referenced this pull request Sep 26, 2026
@robn @lundman
config: refuse to build without fs_context
23b7e92 
Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes openzfs#18339
pull Bot pushed a commit to A-Archives-and-Forks/openzfs that referenced this pull request Sep 26, 2026
@robn @lundman
linux/super: remove support for old mount API
9d1c3b6 
Removing the HAVE_FS_CONTEXT gates and anything that would be used if it
wasn't set.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes openzfs#18339
pull Bot pushed a commit to A-Archives-and-Forks/openzfs that referenced this pull request Sep 26, 2026
@robn @lundman
linux/super: flatten mount/remount into get_tree/reconfigure
9d2a455 
With the old API gone, there's no need to massage new-style calls into
its shape and call another function; we can just make those handlers
work directly.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes openzfs#18339
pull Bot pushed a commit to A-Archives-and-Forks/openzfs that referenced this pull request Sep 26, 2026
@robn @lundman
linux/super: flatten zpl_mount_impl into zpl_get_tree
cc334bb 
Target of opportunity; with no other callers, there's no need for it to
be a static function.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes openzfs#18339
pull Bot pushed a commit to A-Archives-and-Forks/openzfs that referenced this pull request Sep 26, 2026
@robn @lundman
linux/super: flatten zpl_fill_super into zpl_get_tree
9ecec1d 
Target of opportunity; with no other callers, there's no need for it to
be a static function.

Sponsored-by: TrueNAS
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@truenas.com>
Closes openzfs#18339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees

No one assigned

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robn @behlendorf