Skip to content

Fix negative time overflows in DDT pruning - #18886

Merged
behlendorf merged 1 commit into
openzfs:masterfrom
amotin:prune_times
Aug 9, 2026
Merged

Fix negative time overflows in DDT pruning#18886
behlendorf merged 1 commit into
openzfs:masterfrom
amotin:prune_times

Conversation

@amotin

@amotin amotin commented Aug 3, 2026

Copy link
Copy Markdown
Member
  • Account DDT entries created after prune start to histogram bin 0 (now) instead of the last one (long ago) due to negative overflow.
  • Return error when requested to prune for more days than passed since the epoch.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist

@amotin amotin added the Status: Code Review Needed Ready for review and testing label Aug 3, 2026
@amotin
Fix negative time overflows in DDT pruning
371f825 
 - Account DDT entries created after prune start to histogram bin 0
(now) instead of the last one (long ago) due to negative overflow.
 - Return error when requested to prune for more days than passed
since the epoch.

Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 6, 2026
@behlendorf
behlendorf merged commit b4f70cb into openzfs:master Aug 9, 2026
43 of 48 checks passed
@amotin
amotin deleted the prune_times branch August 10, 2026 13:03
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 19, 2026
@amotin @tonyhutter
Fix negative time overflows in DDT pruning
84864d0 
- Account DDT entries created after prune start to histogram bin 0
(now) instead of the last one (long ago) due to negative overflow.
 - Return error when requested to prune for more days than passed
since the epoch.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#18886
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 19, 2026
@amotin @tonyhutter
Fix negative time overflows in DDT pruning
c714cc5 
- Account DDT entries created after prune start to histogram bin 0
(now) instead of the last one (long ago) due to negative overflow.
 - Return error when requested to prune for more days than passed
since the epoch.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#18886
pull Bot pushed a commit to A-Archives-and-Forks/openzfs that referenced this pull request Sep 26, 2026
@amotin @lundman
Fix negative time overflows in DDT pruning
23f05e1 
- Account DDT entries created after prune start to histogram bin 0
(now) instead of the last one (long ago) due to negative overflow.
 - Return error when requested to prune for more days than passed
since the epoch.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#18886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees

No one assigned

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amotin @behlendorf