Skip to content

Test sdist - #109

Merged
goulart-paul merged 4 commits into
oxfordcontrol:mainfrom
tschm:patch-2
Jun 1, 2024
Merged

Test sdist#109
goulart-paul merged 4 commits into
oxfordcontrol:mainfrom
tschm:patch-2

Conversation

@tschm

@tschm tschm commented May 27, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented May 27, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 87.24%. Comparing base (ed73c9d) to head (13c6667).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   87.24%   87.24%           
=======================================
  Files          75       75           
  Lines        6011     6011           
=======================================
  Hits         5244     5244           
  Misses        767      767           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@goulart-paul
goulart-paul changed the base branch from main to develop May 28, 2024 18:44
@tschm

tschm commented May 29, 2024

Copy link
Copy Markdown
Contributor Author

@goulart-paul This I would merge. There is quite some code duplication in pypi.yml and test_pypi.yml. Let's fix them first individually and then "merge" them into one file...

@goulart-paul
goulart-paul changed the base branch from develop to main June 1, 2024 09:08
@goulart-paul

Copy link
Copy Markdown
Member

I am updating these manually to also include names tagged with the os for v4.

You are right that the pypi and testpypi are nearly identical. The testpypi was meant to be temporary when I was changing something else and wanted to try pushing to https://test.pypi.org/ first. It then seemed like a useful thing to keep, but the two should certainly be combined somehow.

@goulart-paul
goulart-paul merged commit c1aaf77 into oxfordcontrol:main Jun 1, 2024
@tschm
tschm deleted the patch-2 branch June 2, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants