Skip to content

fix psd scaling checks - #82

Merged
goulart-paul merged 1 commit into
mainfrom
pg/fix_cholesky_error
Mar 1, 2024
Merged

fix psd scaling checks #82
goulart-paul merged 1 commit into
mainfrom
pg/fix_cholesky_error

Conversation

@goulart-paul

Copy link
Copy Markdown
Member

Fixes a panic / crash condition in PSD scaling step

@codecov

codecov Bot commented Mar 1, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.12%. Comparing base (ed7e193) to head (cb7ca49).
Report is 2 commits behind head on main.

Files Patch % Lines
src/solver/core/cones/psdtrianglecone.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   85.14%   85.12%   -0.02%     
==========================================
  Files          62       62              
  Lines        4402     4404       +2     
==========================================
+ Hits         3748     3749       +1     
- Misses        654      655       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@goulart-paul
goulart-paul merged commit 15e44b3 into main Mar 1, 2024
@goulart-paul
goulart-paul deleted the pg/fix_cholesky_error branch May 17, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant