Repository navigation
Several issues with CacheControl types #2881
Description
This issue is in three parts:
no-transform directive always returns None
This directive has no arguments (either in current RFC 9111 or older RFC 2616)
from werkzeug.http import parse_cache_control_header
cc = parse_cache_control_header("no-transform")
print(f"{cc.no_transform=}")Output:
cc.no_transform=None
Expected: boolean based on presence
min-fresh directive returns "*" if missing required argument
from werkzeug.http import parse_cache_control_header
cc = parse_cache_control_header("min-fresh")
print(f"{cc.min_fresh=}")Output:
cc.min_fresh='*'
Expected: None since the argument is required and "*" doesn't have a semantic meaning for this directive.
type stubs are incorrect
no_cachereturnsstrnotbool.boolproperties never returnNonemax_stalereturns"*"in addition toint.RequestCacheControlimmutability is not reflected.
Environment:
- Python version: N/A
- Werkzeug version: 3.0.2
Activity
RazerM commentedon May 4, 2024
They are all
Noneif not present, the empty value is used if the directive is present but has no argument:Those have optional arguments and
*is at least handy as a truthy value.I agree. iirc Chromium treats max-age without the required argument as if the directive wasn't there.