Skip to content

get(type=) should catch TypeError consistently #2976

Closed

Description

@davidism

#2842 changed TypeConversionDict.get to catch TypeError in addition to ValueError, but other datastructures with get(type=) were not changed. Make them all consistent.

Activity

  1. added this to the 3.1.0 milestone on Oct 30, 2024
  2. self-assigned this
    on Oct 30, 2024
  3. davidism commented on Oct 30, 2024

    @davidism
    MemberAuthor

    Headers only has string values, so a type that raised TypeError on any string would be pointless. So Headers.get can be excluded.

  4. davidism commented on Oct 30, 2024

    @davidism
    MemberAuthor

    Looks like it's only getlist that needs to be updated.

  5. locked as resolved and limited conversation to collaborators on Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions