Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
host_is_trustedvalidates that1 <= port <= 65535. 0 is a valid port, but not in the context of a host.It also disallows leading zeros, for example
08443. I couldn't find a definitive spec for whether this was allowed or not. Firefox will navigate to https://example.com:08443, but rewrites it as8443when clicking the link or entering it in the address bar, and the dev tools shows the request without leading zeros. HTTPWG says nothing about leading zeros. WhatWG URL standard https://url.spec.whatwg.org/#port-state specifies that it is a 16-bit unsigned integer "0 to 65535 inclusive". So I've taken that to mean that leading zeros are not allowed in the port, but that clients might normalize them. That ensures there's not multiple representations of the same value, not sure if that would matter or not.