Skip to content

Issue highlighting on 4.31.19086Β #119

Closed

Description

@DavidNSB

After installing the 4.31.19086 firmware, an attempt to hightlight a phrase, a popup "NickelMenu Could not find the required SelectionMenuView and SelectionMneuController symbols for adding selection menu items (this is a bug)" was displayed. After clicking OK 3 times, the highlight menu was displayed.

Activity

  1. self-assigned this
    on Jan 20, 2022
  2. pgaskin commented on Jan 20, 2022

    @pgaskin
    Owner

    I will try and release a fix for this tonight.

  3. pinned this issue on Jan 20, 2022
  4. shermp commented on Jan 21, 2022

    @shermp
    Collaborator

    @pgaskin do you want me to take a quick look at this once I've decompiled libnickel?

  5. pgaskin commented on Jan 21, 2022

    @pgaskin
    Owner

    Yes, if you want to.

  6. shermp commented on Jan 21, 2022

    @shermp
    Collaborator

    Ok, will do, just waiting for Ghidra to finish chugging away at this.

  7. shermp commented on Jan 21, 2022

    @shermp
    Collaborator

    Looks like SelectionMenuController::lookupWeb() is gone.

    Looks like it may have been replaced with SelectionMenuController::lookupGoogle() and SelectionMenuController::lookupBaidu()

  8. pgaskin commented on Jan 21, 2022

    @pgaskin
    Owner

    Fixed in v0.5.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions