Skip to content

Custom icon for NickelMenu main menu on 4.23.15505Β #84

Closed

Description

@pgaskin

See #78.

Activity

  1. NiLuJe commented on Aug 27, 2020

    @NiLuJe
    Collaborator

    Random thought: instead of/in the meantime, couldn't we simply re-purpose an existing one? (I was thinking of the Erlenmeyer of the "Beta" settings, or any of the existing gear/tool-like ones).

  2. pgaskin commented on Aug 27, 2020

    @pgaskin
    OwnerAuthor

    instead of/in the meantime, couldn't we simply re-purpose an existing one

    I was actually just thinking something along the same line. I'm considering making an experimental option for now to change the path used for the QPixmap, as that would allow loading it from an arbitrary resource or a file. That allows us to sidestep the decisions for this change for now.

    The only thing I'm concerned about is I don't want experimental options to become widely-used and having people complain about breakage/removal/changes later. That's a discussion for #87, though.

  3. added this to the v0.5.0 milestone on Nov 15, 2020
  4. pgaskin commented on Dec 2, 2020

    @pgaskin
    OwnerAuthor

    I've decided to go with an experimental option to change the QPixmap path for now. I'll need to test what happens if it doesn't exist or is invalid, though, to make sure it won't cause any problems.

  5. self-assigned this
    on Dec 2, 2020
  6. added a commit that references this issue on Jan 7, 2021
    cc361da
  7. acestronautical commented on Oct 4, 2022

    @acestronautical

    I tried setting:

    experimental:menu_main_15505_icon_active:/images/reading/beta_features_hit.png
    experimental:menu_main_15505_icon:/images/reading/beta_features.png
    

    but it doesn't seem to be working. Is this supposed to work with the native paths on kobo?
    (I have libra 2)

  8. pgaskin commented on Oct 4, 2022

    @pgaskin
    OwnerAuthor

    Try adding another colon before the path and see if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions